Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 15 Nov 2019 11:17:23 -0500
From:   Johannes Weiner <hannes@cmpxchg.org>
To:     Qian Cai <cai@lca.pw>
Cc:     akpm@linux-foundation.org, surenb@google.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mm/vmscan: fix some -Wenum-conversion warnings
Message-ID: <20191115161723.GB309754@cmpxchg.org>
References: <1573826697-869-1-git-send-email-cai@lca.pw>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1573826697-869-1-git-send-email-cai@lca.pw>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 15, 2019 at 09:04:57AM -0500, Qian Cai wrote:
> The -next commit "mm: vmscan: enforce inactive:active ratio at the
> reclaim root" [1] introduced some GCC -Wenum-conversion warnings,
> 
> mm/vmscan.c:2216:39: warning: implicit conversion from enumeration type
> 'enum lru_list' to different enumeration type 'enum node_stat_item'
> [-Wenum-conversion]
>         inactive = lruvec_page_state(lruvec, inactive_lru);
>                    ~~~~~~~~~~~~~~~~~         ^~~~~~~~~~~~
> mm/vmscan.c:2217:37: warning: implicit conversion from enumeration type
> 'enum lru_list' to different enumeration type 'enum node_stat_item'
> [-Wenum-conversion]
>         active = lruvec_page_state(lruvec, active_lru);
>                  ~~~~~~~~~~~~~~~~~         ^~~~~~~~~~
> mm/vmscan.c:2746:42: warning: implicit conversion from enumeration type
> 'enum lru_list' to different enumeration type 'enum node_stat_item'
> [-Wenum-conversion]
>         file = lruvec_page_state(target_lruvec, LRU_INACTIVE_FILE);

Interesting, it doesn't show these for me with gcc-9.2.0.

We should definitely fix these!

> @@ -2213,8 +2213,9 @@ static bool inactive_is_low(struct lruvec *lruvec, enum lru_list inactive_lru)
>  	unsigned long inactive_ratio;
>  	unsigned long gb;
>  
> -	inactive = lruvec_page_state(lruvec, inactive_lru);
> -	active = lruvec_page_state(lruvec, active_lru);
> +	inactive = lruvec_page_state(lruvec,
> +				     (enum node_stat_item)inactive_lru);
> +	active = lruvec_page_state(lruvec, (enum node_stat_item)active_lru);

This is fragile, as it relies on the absolute values being identical,
which we don't guarantee. However, we do guarantee the relative order
between the LRU items, and we use NR_LRU_BASE for the translation.

Please use NR_LRU_BASE + (in)active_lru here.

> @@ -2743,7 +2744,8 @@ static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc)
>  	 * thrashing, try to reclaim those first before touching
>  	 * anonymous pages.
>  	 */
> -	file = lruvec_page_state(target_lruvec, LRU_INACTIVE_FILE);
> +	file = lruvec_page_state(target_lruvec,
> +				 (enum node_stat_item)LRU_INACTIVE_FILE);

This should just directly use NR_INACTIVE_FILE instead.

Thanks