Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] trace/synthetic_events: increase SYNTH_FIELDS_MAX
To:     Steven Rostedt <rostedt@goodmis.org>,
        Artem Bityutskiy <dedekind1@gmail.com>
Cc:     linux-kernel@vger.kernel.org
References: <20191115091730.9192-1-dedekind1@gmail.com>
 <20191115105227.341c238e@gandalf.local.home>
From:   "Zanussi, Tom" <tom.zanussi@linux.intel.com>
Message-ID: <8751ffdd-ea8c-4aa5-663d-0d7d0fd0886d@linux.intel.com>
Date:   Fri, 15 Nov 2019 10:21:05 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <20191115105227.341c238e@gandalf.local.home>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Steve and Artem,

On 11/15/2019 9:52 AM, Steven Rostedt wrote:
> On Fri, 15 Nov 2019 11:17:30 +0200
> Artem Bityutskiy <dedekind1@gmail.com> wrote:
> 
>> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>>
>> Increase the maximum allowed count of synthetic event fields from 16 to 32
>> in order to allow for larger-than-usual events.
> 
> I'm fine with this, Tom are you OK with it?

Yeah, looks good to me.  Thanks for the patch, Artem.

Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>

Tom

> 
> -- Steve
> 
>>
>> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>> ---
>>   kernel/trace/trace_events_hist.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
>> index 7482a1466ebf..f49d1a36d3ae 100644
>> --- a/kernel/trace/trace_events_hist.c
>> +++ b/kernel/trace/trace_events_hist.c
>> @@ -23,7 +23,7 @@
>>   #include "trace_dynevent.h"
>>   
>>   #define SYNTH_SYSTEM		"synthetic"
>> -#define SYNTH_FIELDS_MAX	16
>> +#define SYNTH_FIELDS_MAX	32
>>   
>>   #define STR_VAR_LEN_MAX		32 /* must be multiple of sizeof(u64) */
>>   
>