Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4694434ybc; Fri, 15 Nov 2019 08:36:56 -0800 (PST) X-Google-Smtp-Source: APXvYqztLqbaFlND5rFvRAPSLGCnLCZoapMf0+WXPhZEu1S5MoZkVwMUQAk46Uc5+8qEykyMelO3 X-Received: by 2002:a17:906:4bcb:: with SMTP id x11mr2165139ejv.100.1573835816365; Fri, 15 Nov 2019 08:36:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573835816; cv=none; d=google.com; s=arc-20160816; b=JeeEOlt31nKVYdrnIxDHDnt9HHqc6FBQGI8X91NOwm3C50JToIHSH+XB3A1N16rqYa Fk6tRPcCzXaNtpeKvfsbYLIRVYOM5IwfDvXg7WkOCg3Tw2yNT+id77sZxwGJba0vHrd1 EBLsOMcawiaxEZWeliGofVm/4HxRtnzYKXQBhdWsmNrGh6Sau7RGih0NfudhF0sEyZt1 eELwsfHcPg4rtS52JDyynlZzI75KqiZwKO5aqy3LAS1nFMYtNO7YSasdY1ieJ4h7ZCiW Devfspwml11uG2bSopR7GAtxIXxUIaHAMOZ2rRlUF3qsBZBjr50+eyBlpL2fyG+LKpaW jswQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:user-agent:in-reply-to:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=CoBpdLu+jjhEff2mhAg7g0GBmy6uvMAfLJMPx0Oznc8=; b=X+hGiK/wf+jzdGyZnxElgmAjE66fqwKEE06WleTrAcksORaE+QyyPkdja5AbS7mJyh 2hmvD9t/i34RgrMHUsdDOlaELLAbXswWtMAj1s3/xGNbtybw2HqcT8HWCE+JWVi+qeQr W/+Wtx8TwO5HnI6paS/haUFd4XsQAwj+80gvGsK9mh/I/M/c731iid79XZ4EGv2U4S5g Dc9xV96ezmCFeLr/a9vNKTJ2/KMNJWyvaXBrvd0t/BoY6ye2RwW9IjPNdljbCy7QmEER PWjhtTaCcxijuII/rpTMbKIJY9vGYMv8d0sFl7Rl1aLBeeH40d79NoJRBXDdxLMgBvls Dbmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CocXL900; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f37si7710785eda.190.2019.11.15.08.36.31; Fri, 15 Nov 2019 08:36:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CocXL900; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727558AbfKOQdT (ORCPT + 99 others); Fri, 15 Nov 2019 11:33:19 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:39230 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727531AbfKOQdT (ORCPT ); Fri, 15 Nov 2019 11:33:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573835598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CoBpdLu+jjhEff2mhAg7g0GBmy6uvMAfLJMPx0Oznc8=; b=CocXL900M5qe204dbjJUvmNdKChxhVCskxbwOqwnHpa933LbfBXo2J/J6JGec4AQJ23iev bi5/uiCHPqTAOeTfziE5Syy5SPzDUZ3W5lSHYVkeVrhwY96AEJT6UPPQW4tuI10fs7pmne kXdwyYJjVuVzpVDfqmcJ2JGe1aH/YK0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-242-viOPJ7bnNzO4e6bAbfKvjw-1; Fri, 15 Nov 2019 11:33:15 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 13496DBD0; Fri, 15 Nov 2019 16:33:13 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.44]) by smtp.corp.redhat.com (Postfix) with SMTP id E46C967E61; Fri, 15 Nov 2019 16:33:10 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 15 Nov 2019 17:33:12 +0100 (CET) Date: Fri, 15 Nov 2019 17:33:09 +0100 From: Oleg Nesterov To: Adrian Reber Cc: Christian Brauner , Eric Biederman , Pavel Emelyanov , Jann Horn , Dmitry Safonov <0x7f454c46@gmail.com>, Andrei Vagin , Rasmus Villemoes , linux-kernel@vger.kernel.org, Mike Rapoport , Radostin Stoyanov Subject: Re: [PATCH v11 1/2] fork: extend clone3() to support setting a PID Message-ID: <20191115163308.GC25528@redhat.com> References: <20191115123621.142252-1-areber@redhat.com> MIME-Version: 1.0 In-Reply-To: <20191115123621.142252-1-areber@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: viOPJ7bnNzO4e6bAbfKvjw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/15, Adrian Reber wrote: > > v11: > - abort alloc_pid() correctly if one of the PIDs specified in > set_pid[] is invalid (Andrei) > --- > include/linux/pid.h | 3 +- > include/linux/pid_namespace.h | 2 + > include/linux/sched/task.h | 3 ++ > include/uapi/linux/sched.h | 53 +++++++++++++++++--------- > kernel/fork.c | 24 +++++++++++- > kernel/pid.c | 72 +++++++++++++++++++++++++++-------- > kernel/pid_namespace.c | 2 - > 7 files changed, 122 insertions(+), 37 deletions(-) Reviewed-by: Oleg Nesterov