Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v11 1/2] fork: extend clone3() to support setting a PID
From:   Dmitry Safonov <0x7f454c46@gmail.com>
To:     Adrian Reber <areber@redhat.com>,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Eric Biederman <ebiederm@xmission.com>,
        Pavel Emelyanov <ovzxemul@gmail.com>,
        Jann Horn <jannh@google.com>, Oleg Nesterov <oleg@redhat.com>,
        Andrei Vagin <avagin@gmail.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc:     linux-kernel@vger.kernel.org, Mike Rapoport <rppt@linux.ibm.com>,
        Radostin Stoyanov <rstoyanov1@gmail.com>
References: <20191115123621.142252-1-areber@redhat.com>
 <fada5995-7fcc-7ca8-0933-4d0f52deef6e@gmail.com>
Message-ID: <446bbd86-1cbb-fcec-92b2-69a9f996c78e@gmail.com>
Date:   Fri, 15 Nov 2019 17:02:13 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <fada5995-7fcc-7ca8-0933-4d0f52deef6e@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/15/19 4:54 PM, Dmitry Safonov wrote:

> [..]
>> +	size_t set_tid_size;
>> +	__aligned_u64 set_tid_size;
> 
> [..]
>> +		.set_tid_size	= args.set_tid_size,
> 
> Is sizeof(size_t) == 32 on native 32-bit platforms?
> Maybe `args.set_tid_size` should be checked?

Nevermind, I missed that
+	if (unlikely(args.set_tid_size > MAX_PID_NS_LEVEL))
+		return -EINVAL;

is checked for `args' - it should be good enough.

Thanks,
          Dmitry