Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4770487ybc; Fri, 15 Nov 2019 09:47:38 -0800 (PST) X-Google-Smtp-Source: APXvYqwyT8c6w5LT2oaXscPuZ3iFKe6ECZkd5qlGU5Law+m/AjfX0J5t63TVxkIM40+U5aKmdrfm X-Received: by 2002:a17:906:1d59:: with SMTP id o25mr2486556ejh.17.1573840058018; Fri, 15 Nov 2019 09:47:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573840058; cv=none; d=google.com; s=arc-20160816; b=rgplwZ/Kvc9JlX4O9mWiYU5be5QoiOHk7BkUA9Q3eGYhWXyFFD9IowurRrReacYCNK rYNAgaaQbPWAPLdSq40MoaDaO1onMpXKf6z5SfoKqxRrxAKPDaqu7E1EVQiyJOJl80Jj q93fyj2O6F4VJacJv1mn5s+MkwJrC+sNqUCBs58YD+Ecz11gKWUl9qrRxxpuRci4Ceen qLl6VGU47OZ6krCc4Ov88oeemP+Pk/na4tPA/WSeDp01cLjrSSF14SSgjnFVwb/y2QWK hSkN+LBF4jtkgyGulKg+u8XAILt2v0IyNcnSMSG9kcROw2suL7ZBiT0TxqgNz9MKTZ1k 44kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=G+gMUpNvXVmANKnt9biF9wy+hihvyOaCvIM2XBgwx5k=; b=KefUypHKVDfFXO3Faj+45sw14UtHrLtIRA8wJX98nU1AOPeECXlhX41hLjzUoTuGN9 AoJpsMje6u+dg/hTPEftbGY00LzIYqIq8I6GOKuh3PvAMA+pTQvssk7iOrL02j9E4VWg SaEhmot7mULZkRftTy6M754XuY7ktXjz7PI5i5ObLe5npSmOLVNV/pHNeSpnz6i/kTki DtzFC8M6AvI34AhzCPCLiqGVaxXHjiLjUt+yYWFJ0lDgPfljybtMbaEC+o7aEc6wev9F M7ulb1W2upiADEHJaPE/wdSqn86Pg/MFFbLuoVxH/Q6vN2S/a9ShxOWmBl9oRK/zaY2q 7dmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (no key) header.i=@vger.kernel.org header.b=rjHnXjwB; dkim=fail header.i=@uniroma2.it header.s=rsa201904 header.b=qhegkJsU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=uniroma2.it Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l18si6359418edv.348.2019.11.15.09.47.12; Fri, 15 Nov 2019 09:47:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (no key) header.i=@vger.kernel.org header.b=rjHnXjwB; dkim=fail header.i=@uniroma2.it header.s=rsa201904 header.b=qhegkJsU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=uniroma2.it Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726910AbfKORpk (ORCPT + 99 others); Fri, 15 Nov 2019 12:45:40 -0500 Received: from smtp.uniroma2.it ([160.80.6.23]:52404 "EHLO smtp.uniroma2.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbfKORpk (ORCPT ); Fri, 15 Nov 2019 12:45:40 -0500 Received: from smtpauth-2019-1.uniroma2.it (smtpauth.uniroma2.it [160.80.5.46]) by smtp-2015.uniroma2.it (8.14.4/8.14.4/Debian-8) with ESMTP id xAFHiuoF021741; Fri, 15 Nov 2019 18:45:01 +0100 Received: from lubuntu-18.04 (unknown [160.80.103.17]) by smtpauth-2019-1.uniroma2.it (Postfix) with ESMTPSA id 6E582120288; Fri, 15 Nov 2019 18:44:52 +0100 (CET) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=uniroma2.it; s=ed201904; t=1573839892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G+gMUpNvXVmANKnt9biF9wy+hihvyOaCvIM2XBgwx5k=; b=rjHnXjwBoLKZ7zt0plnJZANkLWcH014rXejP75TbOEZ4lQQRRvgHpzUx8oy5Sv+gWBCvyL +zo6ApJbV6PQ+hAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniroma2.it; s=rsa201904; t=1573839892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G+gMUpNvXVmANKnt9biF9wy+hihvyOaCvIM2XBgwx5k=; b=qhegkJsU5LSEbbqG9RCyf7ATS3q1ZekBwgitPl2tilRWDIdg10dMctXpQ0AADtMOR3NLI7 EhuPGSRkGEBtzB+nG/cnNXYNhmEdRpPORRZzqemjKyVLunWNqcE7PK4gwpMmaP2USux/q9 n/IrlJh0R+nsBDrJm2izgiNAsuVZP3v8IGGrbsfnqlHAiu5BKMx2BtbujZWC/aGIrnDvOj ZMJawXxrZ7rAAHcSLpPJ2xczegYfSCLTu2Pnv8gHdN3JWPtaeI4jKRih1tV6aBKq1M9iqK 1QMTwaFSDPIyulnSDwYg/ZMl2oKsw2eTmtfooYGSpz/IzfuzlD9YtRMpS/3rpg== Date: Fri, 15 Nov 2019 18:44:52 +0100 From: Andrea Mayer To: David Miller Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, dav.lebrun@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrea.mayer@uniroma2.it Subject: Re: [net-next, 1/3] seg6: verify srh pointer in get_srh() Message-Id: <20191115184452.828eb26ff29c90ff432bc2f5@uniroma2.it> In-Reply-To: <20191114.174512.2282984013110706126.davem@davemloft.net> References: <20191113192912.17546-1-andrea.mayer@uniroma2.it> <20191113192912.17546-2-andrea.mayer@uniroma2.it> <20191114.174512.2282984013110706126.davem@davemloft.net> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.100.0 at smtp-2015 X-Virus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Nov 2019 17:45:12 -0800 (PST) David Miller wrote: > From: Andrea Mayer > Date: Wed, 13 Nov 2019 20:29:10 +0100 > > > pskb_may_pull may change pointers in header. For this reason, it is > > mandatory to reload any pointer that points into skb header. > > > > Signed-off-by: Andrea Mayer > > This is a bug fix and must be separated out and submitted to 'net'. > > Then you must wait until 'net' is merged into 'net-next' so that you > can cleanly resubmit the other changes in this series which add the > new features. > > Actually, patch #2 looks like a bug fix as well. Hi, thanks for your review. I will submit the first two patches to 'net'. Regards, Andrea Mayer