Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4778571ybc; Fri, 15 Nov 2019 09:56:05 -0800 (PST) X-Google-Smtp-Source: APXvYqyoxtAdZo6B9e7Ep7lm5uXqdo/xNDXU//6jHRPjappjBylBgz9FMDbQMW9y0ZEWeiExKFiF X-Received: by 2002:adf:f084:: with SMTP id n4mr9527395wro.369.1573840565142; Fri, 15 Nov 2019 09:56:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573840565; cv=none; d=google.com; s=arc-20160816; b=hWla8ED5mU69OQRrZNfiaoDdZmcoyl/rpZRZOWJfw0yuEpOnUqIJ8Psc8qE9/W7BJR 6xSxI3Wei7Lc8DroiGsJ+oe6MLmcXuKHOPxrBYrVSr6RKrDnKP7eLNu5aJcpy6oexS7A l+7eMFTnkgkUUelNTmLsZwPXOt56Fv7Bnsbx7V+tTKSJHxWMiio+IfeEO/DYliYwFZ9b DiM8/2k0irG+kQW2hhl83ATEnDm4iRXTQwwTqnDUWMtHPpMRDos6GKmGVCtp2HmluJWB tIRIoS/Te5HmcuAym4CssstxvGIWkpgycfLjPewTwriA5Y/XfiMC0WY19R5bquvp9FT5 XMBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:user-agent:in-reply-to:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=dGqn2wXaDwx9A6TmaPBjbD4iV16jXQiloPf6sWcs7RQ=; b=PLFGmeGc3kDiMFkFPbMOZXGiFsz/+CHloPvnhKxvAe+MAmuXJwJdfh4UpmFEeEUW0C Mm4+h0VpzsttY6JUoDy5IGq4mW7IvRNGmWSZwD7+tg+mOL3Ol/ssIGpnnJW/KveanXvz tx3RJaIy4R8YN5GFk1djpZrd5IZjFCfXPFdX0WXnjEXgTm38TWnyBYc7yVH7wrjUIFmt XMjbKUL1Hkh5ERrJ4tNxYUS9AWpUs7qEuTfMV8T89zLz9Biwy9vOWD+UaT7Diyuix+vS X/pp4Li+tK8z3YsXFd4v32uz+sbvxyPgDKqNwc1l2lB3m2EcFyRR+DjOqzjLzqtxquJE js6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cMX8at+7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y26si7022045edb.360.2019.11.15.09.55.40; Fri, 15 Nov 2019 09:56:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cMX8at+7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726822AbfKORwe (ORCPT + 99 others); Fri, 15 Nov 2019 12:52:34 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:55152 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726131AbfKORwe (ORCPT ); Fri, 15 Nov 2019 12:52:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573840353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dGqn2wXaDwx9A6TmaPBjbD4iV16jXQiloPf6sWcs7RQ=; b=cMX8at+7lw88n56wv6sKfdo2cvRWF1zSRrq+B3hj4nPzYOXg3pwOI+kNu+YH9olxkdYzq4 623++W4JZlw5WomSiFmlKcByiuY6hZiaLRKtryA7whlHsWyMMxrq8lPRhIpxs20a7UVu2z bO3mJF3IA2DMQki01TDK5RfV8S2MYnM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-82-4q1upNmyPdygPntzOWZ9Hg-1; Fri, 15 Nov 2019 12:52:29 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D049A801E7E; Fri, 15 Nov 2019 17:52:27 +0000 (UTC) Received: from treble (ovpn-120-26.rdu2.redhat.com [10.10.120.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4EF2360BE1; Fri, 15 Nov 2019 17:52:26 +0000 (UTC) Date: Fri, 15 Nov 2019 11:52:24 -0600 From: Josh Poimboeuf To: Shile Zhang Cc: Peter Zijlstra , Masahiro Yamada , Michal Marek , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: Re: [RFC PATCH v4 0/7] Speed booting by sorting ORC unwind tables at build time Message-ID: <20191115175224.ozuiei2vlfvynok5@treble> References: <20191115164539.57930-1-shile.zhang@linux.alibaba.com> MIME-Version: 1.0 In-Reply-To: <20191115164539.57930-1-shile.zhang@linux.alibaba.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: 4q1upNmyPdygPntzOWZ9Hg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 16, 2019 at 12:45:32AM +0800, Shile Zhang wrote: > Hi, >=20 > I refactored the code, followed by Peter's suggestions in v3, thank you! > Any suggestions and comments are welcome! >=20 > Thanks! >=20 > Changelog: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > v3->v4: > - Code refactored for Peter's review findings and suggestions. Hi Shile, I haven't given it a proper review yet, but one minor suggestion. In general it's good practice to wait at least a few business days before posting a new version of a patch set. That way it gives people time to review, and it also helps to avoid flooding people's inboxes. --=20 Josh