Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191114142707.1608679-1-areber@redhat.com> <20191114142707.1608679-2-areber@redhat.com>
 <20191114183421.GA171963@gmail.com> <20191115151420.GC20767@dcbz.redhat.com>
In-Reply-To: <20191115151420.GC20767@dcbz.redhat.com>
From:   Andrei Vagin <avagin@gmail.com>
Date:   Fri, 15 Nov 2019 10:39:32 -0800
Message-ID: <CANaxB-wWfXmFaFD7GuXe6GaOnEQhTCS-7cPa24L00dxux5YtOQ@mail.gmail.com>
Subject: Re: [PATCH v10 2/2] selftests: add tests for clone3() with *set_tid
To:     Adrian Reber <areber@redhat.com>
Cc:     Christian Brauner <christian.brauner@ubuntu.com>,
        Eric Biederman <ebiederm@xmission.com>,
        Pavel Emelyanov <ovzxemul@gmail.com>,
        Jann Horn <jannh@google.com>, Oleg Nesterov <oleg@redhat.com>,
        Dmitry Safonov <0x7f454c46@gmail.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        LKML <linux-kernel@vger.kernel.org>,
        Mike Rapoport <rppt@linux.ibm.com>,
        Radostin Stoyanov <rstoyanov1@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 15, 2019 at 7:14 AM Adrian Reber <areber@redhat.com> wrote:
>
> On Thu, Nov 14, 2019 at 10:34:21AM -0800, Andrei Vagin wrote:
>
> > > +   snprintf(proc_path, sizeof(proc_path), "/proc/%d/status", pid);
> > > +   f = fopen(proc_path, "r");
> > > +   if (f == NULL)
> > > +           ksft_exit_fail_msg(
> > > +                   "%s - Could not open %s\n",
> > > +                   strerror(errno), proc_path);
>
> If the child does not exist anymore, the test will fail here and exit.
>
> Besides this while() I tried to address all your comments in v11. Any
> further comments on the test?

No, I don't have any other comments.

Thanks,
Andrei