Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4836271ybc; Fri, 15 Nov 2019 10:50:56 -0800 (PST) X-Google-Smtp-Source: APXvYqzsXboc6Z2NOsOqut4QPpyZ+BJCG/uwnKi6fm7acfW9B4YWc8aupevBPP9w3YApQib2puxJ X-Received: by 2002:a17:906:ce2f:: with SMTP id sd15mr3045295ejb.270.1573843856762; Fri, 15 Nov 2019 10:50:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573843856; cv=none; d=google.com; s=arc-20160816; b=FyXamaMjkyuWKZsMda0QpJ8GG35iXzC4skSW6oLzmwDOyDi2a+6WMqkfZVzHLqxYcK yo2+H6JxEep6bSO0E/DbWvnowwcobcH7C12LJS+4cc8Lh171ti5obcv/sGEpZrOO5akx +q0gRo6Vp0t/ra5AH9ccgjwNlFfvvz1+sHIrouhNB+pFaNlgU5cJP1KZ5iRK/KsDqIxY IW8ujUyknaC0tx99JjbCXoFoBqoT+vgDHvr9fuz+XYY/6UOnLaXv8nLK9zK6gYPJtTcV c9uKKNcTVOKPvhooQufWegl4AHU3kKLK0ujwknRcUBngu+jskRlACnKen63dUZd8c9NS w2FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:user-agent:from:subject:to:cc :references:in-reply-to:content-transfer-encoding:mime-version :message-id:dkim-signature; bh=C9Cj36xd1lbZSQMwVwr0IaZNtwh3zNWL2afAmoYCPyY=; b=pPpSYiH22BYeyY8acBAdq/Bxhskehd1yJur6pumkSmBMxkdFf9Jar9OqyfP8ngxs3O +nSvY1AnsO3Lq0toa7p4K2xabrjXIRnli/TpxgFvxV+G3Inyhewsv9Yz15U+0zSf97qU D31JLhQWWNSQePxmsBlStQ/2gC207y7VThj7OsZrvBqFmK45W8l1nlwj9EtzitylgN4h OqUEWimX1GxQgJjhJ0anp3edRyNzOBxwyHDX4ufVEgp2GuNLkSkWuMRhtI9iQ8GZH3YG AC46kUsawZDalf1ACdrf4FDWuawE7LA2NbZ5PAPqteK9zpRo8UjmwyX0YXXlEXqq6w0O GxNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="iD/GEn5L"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d1si6075273ejh.281.2019.11.15.10.50.32; Fri, 15 Nov 2019 10:50:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="iD/GEn5L"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727020AbfKOStO (ORCPT + 99 others); Fri, 15 Nov 2019 13:49:14 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:33412 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726661AbfKOStO (ORCPT ); Fri, 15 Nov 2019 13:49:14 -0500 Received: by mail-pf1-f196.google.com with SMTP id c184so7114797pfb.0 for ; Fri, 15 Nov 2019 10:49:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:cc:to:subject:from:user-agent:date; bh=C9Cj36xd1lbZSQMwVwr0IaZNtwh3zNWL2afAmoYCPyY=; b=iD/GEn5Livuy+b4yiVVH6UhsUI2OG3nT1mwV4ZBVP6vi7ngBjR7d2kHSHVMPUPdcZD BBxzvZrjsmwPS6SIfQ8SVvnqtqlStH/zk0U3YzPY5QMNs3oxFmMN30axtfmucEvu/N+c 6Id/dSsAKReBxANrXCegz5xpuqCHitVUF0c1c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:cc:to:subject:from :user-agent:date; bh=C9Cj36xd1lbZSQMwVwr0IaZNtwh3zNWL2afAmoYCPyY=; b=gJykxjwm6c8wuTwznPhAaFW4fWJkyJLZLI0zeH/Yp8ph1WQ3gvy9Asq1gm1741aA8C rWpf6JxZNf15lHLdHUrs6mOUrgUuMtfs1RYsCPF7jFAovidVIzCtSLXksaV6bC8F5XXL TgLlC4E+rpQ0zTMFIHjpLM0z8mMaoojz1h6tAtbSkMKwYqi+NwqxvEw40peMxwMGwIo6 2iaM93y4L4i/w5d2ukOa4eNgyTnOAAyqyo50mDAm6U4ujlroAuTFXCJjrVvzTi298Ajj rFrqxpFX6qbbRvQ/0epbEdv47zu2HPVgZhFvM56mGlm0syFxq94oi3vw2M6kbd22gHfx aZJg== X-Gm-Message-State: APjAAAXnPFlbI3QYnqiKZyF70YzDrhwFqANnBtU+ePE2hwuG9VSYYLzX Tmow0q+q6yWvZlS+W9mhGTWTxJo1KoM= X-Received: by 2002:aa7:9f0e:: with SMTP id g14mr19827730pfr.202.1573843753287; Fri, 15 Nov 2019 10:49:13 -0800 (PST) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id v14sm10822561pfe.94.2019.11.15.10.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2019 10:49:12 -0800 (PST) Message-ID: <5dcef328.1c69fb81.a1a73.f6cc@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1573756521-27373-4-git-send-email-ilina@codeaurora.org> References: <1573756521-27373-1-git-send-email-ilina@codeaurora.org> <1573756521-27373-4-git-send-email-ilina@codeaurora.org> Cc: evgreen@chromium.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mkshah@codeaurora.org, linux-gpio@vger.kernel.org, agross@kernel.org, dianders@chromium.org, Lina Iyer To: Lina Iyer , bjorn.andersson@linaro.org, linus.walleij@linaro.org, maz@kernel.org Subject: Re: [PATCH 03/12] drivers: irqchip: pdc: Do not toggle IRQ_ENABLE during mask/unmask From: Stephen Boyd User-Agent: alot/0.8.1 Date: Fri, 15 Nov 2019 10:49:11 -0800 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Lina Iyer (2019-11-14 10:35:12) > When an interrupt is to be serviced, the convention is to mask the > interrupt at the chip and unmask after servicing the interrupt. Enabling > and disabling the interrupt at the PDC irqchip causes an interrupt storm > due to the way dual edge interrupts are handled in hardware. >=20 > Skip configuring the PDC when the IRQ is masked and unmasked, instead > use the irq_enable/irq_disable callbacks to toggle the IRQ_ENABLE > register at the PDC. The PDC's IRQ_ENABLE register is only used during > the monitoring mode when the system is asleep and is not needed for > active mode detection. >=20 > Signed-off-by: Lina Iyer > --- Reviewed-by: Stephen Boyd