Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4887220ybc; Fri, 15 Nov 2019 11:37:45 -0800 (PST) X-Google-Smtp-Source: APXvYqypeIpNmxWYjZNDME6/uJqgqmZM3vznICb2KDQF1K/JSe4P96HglXQexeDuzWR2daTiB3IX X-Received: by 2002:a17:906:1c4d:: with SMTP id l13mr3193520ejg.308.1573846664938; Fri, 15 Nov 2019 11:37:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573846664; cv=none; d=google.com; s=arc-20160816; b=o2bZq3AHH6Es2p3QNjdIcZ3uih8dERBnfTjdtXkdekkFsUMSAt/z6ZOPsZPZzNCW+G 1tHNywHZqZcpynATvDKX9yyM4En6HEW4WjLhLyud05mhuzfdL1Ljcts39wr4DBBEBm5p n+Agj9y75YUo7fXNQjSdCpXWzWVVyncrxxPixhZ5PD/EFzHC7j8cVn423TCxEjShasvu kHihbobfT0D7DPG2xdeh7clchmpUcx8rRDBXoBuQ3IhRmH3Swthph3H1/nUx5+qEQmVG nWEPDp52boVtayA+YdK/MBFo3V+3pmJrTDAyhuqJQPWrTsNuASp1QKAWEwkPWfKEhNhn bfnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:user-agent:from:subject:to:cc :references:in-reply-to:content-transfer-encoding:mime-version :message-id:dkim-signature; bh=0GdbKxm4O06qcVrBG5OQKzuSxJR0rALm31Y5pRBreDU=; b=JsYg0RZgtPS/KeqMhdCyVdN1ct+0neg/y4Du88dMVlzmLyKcG+UtWLnrtqulmADILG 3rJf+u2JQrDfHTRHM20FXM+YRR5wZWoaCGjzXLhzotQy+7Zs84mDVYCASuTUptXlv3HO rvB9lwGkGE9KI5viOg9W0IPdW+RoYIGwcTuvx2EyJh12wEP4LDFBUGkbx2gHGuQK0FPm U15NDwZN9v2HBU8PxE6mobkTApThzAE+6+a7bmr8PygSKA1rg5LB88vWTUfxk/XSNRw6 uFGCaz9SPCb7I3cdycrI5EVPd8jfOPjGjOENw7NAEmrKKL93eSzbCYgNHfgW8dHgzxyk 5VCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nNA3Mbuj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a9si8056308edm.231.2019.11.15.11.37.18; Fri, 15 Nov 2019 11:37:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nNA3Mbuj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726550AbfKOTf1 (ORCPT + 99 others); Fri, 15 Nov 2019 14:35:27 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:35320 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726640AbfKOTf0 (ORCPT ); Fri, 15 Nov 2019 14:35:26 -0500 Received: by mail-pl1-f195.google.com with SMTP id s10so5350941plp.2 for ; Fri, 15 Nov 2019 11:35:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:cc:to:subject:from:user-agent:date; bh=0GdbKxm4O06qcVrBG5OQKzuSxJR0rALm31Y5pRBreDU=; b=nNA3MbujN/YiXOf2jwbxnXZ9cJW2oKdlhQCn0HBLJ7iLOlsKtLLgnNI2i/lOZu9x96 tqraB0HHiCwLo2yJKhnm2LSpsDAvYr0gTm2PhLBi5K1p4T+NmJyfqacVSK7vGnKEqN7K ZjacI8QSmMk4RkPCkYwyoFRGoF/dz0Ew+6kKA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:cc:to:subject:from :user-agent:date; bh=0GdbKxm4O06qcVrBG5OQKzuSxJR0rALm31Y5pRBreDU=; b=cQNtIaIAmVFis38c2W4KY6swn3+U5gPNRUCAV759X8sPyoQsXnT8M+9EG3l9LLO1Y7 J8mz33oVLmgl+lBlOpAY+b/7U/KDAEYtIDUFMPsfZ4LPnOiW5uqrYrsxklBmPQROzkEa ao54agEi7e1TT2wNC4CGvK6wRAcN/T3vE6QpTbhxUKPKhu9J1pJxkkIP9mYCMEbnvvAH T7J0Fsi1tERmgnsHScxEpLqUdRx1SLDq2adhV9fiEC62Aa7z2FSHgy7wCppHPG9SJX2B xkhn8Ng/CZEXnjO2z+3NGk9rBzTL8vCxmI34fqmw9s8qRafYuQueKqylBq7Fdm6CdsiP xk7Q== X-Gm-Message-State: APjAAAXYMnRTeW2V9B7w12O6iA6EShFze0nXXRHbT0yxbJWbldaBpcJe r+ugbmUhFyA9VSuVeSZMywpY5w== X-Received: by 2002:a17:90b:3d3:: with SMTP id go19mr21846617pjb.78.1573846526161; Fri, 15 Nov 2019 11:35:26 -0800 (PST) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id e17sm11201274pgg.5.2019.11.15.11.35.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2019 11:35:25 -0800 (PST) Message-ID: <5dcefdfd.1c69fb81.c5332.fbe0@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1573756521-27373-1-git-send-email-ilina@codeaurora.org> References: <1573756521-27373-1-git-send-email-ilina@codeaurora.org> Cc: evgreen@chromium.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mkshah@codeaurora.org, linux-gpio@vger.kernel.org, agross@kernel.org, dianders@chromium.org, Lina Iyer To: Lina Iyer , bjorn.andersson@linaro.org, linus.walleij@linaro.org, maz@kernel.org Subject: Re: [PATCH 00/12] Support wakeup capable GPIOs From: Stephen Boyd User-Agent: alot/0.8.1 Date: Fri, 15 Nov 2019 11:35:24 -0800 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Lina Iyer (2019-11-14 10:35:09) > Hi all, >=20 > Thanks for all the reviews. >=20 > Here is the next spin of the wakeup capable GPIO support. In order to > facilitate basic support available in the kernel, I have dropped the SPI > register configuration. The feature was added when this series was > restarted based on new hierarchy support in gpiolib. But, the SPI > configuration can be done in the firmware. This would avoid a whole lot > of code in linux that serve little to no purpose. Users of GPIO never > have the need to change the trigger type (level edge and vice-versa) and > the basic configuration can be set in the firmware before boot. Awesome! I'm glad we don't need to worry about configuring that in the kernel.