Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4964880ybc; Fri, 15 Nov 2019 12:45:09 -0800 (PST) X-Google-Smtp-Source: APXvYqx/L47TbYYs/IRbfDonssSf5l+b+hkpiCvrMUrjJHhLfbXz4pMalp5Opzj/Y0C0T7cobrAu X-Received: by 2002:a17:906:505:: with SMTP id j5mr3684928eja.167.1573850709472; Fri, 15 Nov 2019 12:45:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573850709; cv=none; d=google.com; s=arc-20160816; b=pUBW0s0oO7i4lk/7eIZjoYS+vWloGa6wdNUau9QyGk9xrAk8AF/Z/Plrk4jwb9GlCP dbmZ291a0RnmxTygBlAmeE1WaiAdqPU1e9sefsAZN6Ax/YSyyEET3qn3q2rYNhV0Q3Ea c9ybAtzJ+70ArbbZ6NF0BGeDkFeJOqak2W1jnJOTrSRPMgFT4/8ZBo7+CVxECWEab5o+ b2U1ApfTaM5zpM7yNrmi0cNmrAmZeJYEuec04OHiIElSqr8mORzEsES7REc9Tcn50iOo lD1Owu+OlBQKZJ3m8qci7p8iXYwJ85Ez2p6IyDiyMjh8RlTf7m1cEg46wOYsocxuG90s evjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=dewIYRWQXBqS8pUkHWaHbrF1l3qy5OZAclvIh4yi1rQ=; b=xIW9EY3Olj+dwmKDkqGjmC4tx25WXegx1VI1IRS04lO76ex5WM68wwepDmfPKbEL+Y St0tV2GLEnndM9clNe9HxLcisv4nCRe7qy9OaJPbZq1z84juYQ3kMKdt5OE+6AwC5QtZ xjKEstMKc0XOPP9r9RofkvNj3Y/Z6ZAeFmOqPv5wR3Bj9pmCPZor8hYTzCHlyZT0iGbt zKWrY/7DL4mWp1qzngbqd8VlgxTIShwqmdhbnU4aLIN0b/OplET/AoAFi1xA898OyuhQ 0DJOoua8p5SdGM0bXCRPdX7+nGSviLNtzq6+KbVHXhl+loFVvnC3qtBg8cxzqwsD0sO/ YrTg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id lw2si6483607ejb.440.2019.11.15.12.44.44; Fri, 15 Nov 2019 12:45:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727077AbfKOUn0 (ORCPT + 99 others); Fri, 15 Nov 2019 15:43:26 -0500 Received: from mx2.suse.de ([195.135.220.15]:56574 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726567AbfKOUnZ (ORCPT ); Fri, 15 Nov 2019 15:43:25 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 52C57B24F; Fri, 15 Nov 2019 20:43:23 +0000 (UTC) Date: Fri, 15 Nov 2019 12:39:06 -0800 From: Davidlohr Bueso To: Peter Zijlstra Cc: mingo@kernel.org, will@kernel.org, oleg@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, bigeasy@linutronix.de, juri.lelli@redhat.com, williams@redhat.com, bristot@redhat.com, longman@redhat.com, jack@suse.com Subject: Re: [PATCH 1/5] locking/percpu-rwsem, lockdep: Make percpu-rwsem use its own lockdep_map Message-ID: <20191115203906.fbo6t7d2n6xk3saw@linux-p48b> References: <20191113102115.116470462@infradead.org> <20191113102855.696893455@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20191113102855.696893455@infradead.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Nov 2019, Peter Zijlstra wrote: >@@ -37,7 +48,7 @@ static inline void percpu_down_read(stru > { > might_sleep(); > >- rwsem_acquire_read(&sem->rw_sem.dep_map, 0, 0, _RET_IP_); >+ rwsem_acquire_read(&sem->dep_map, 0, 0, _RET_IP_); Unrelated to this patch, but we also need a might_sleep() annotation in percpu_down_write(). Thanks, Davidlohr