Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 15 Nov 2019 16:08:33 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, Tang Chen <tangchen@cn.fujitsu.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Keith Busch <keith.busch@intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Jani Nikula <jani.nikula@intel.com>,
        Nayna Jain <nayna@linux.ibm.com>,
        Michal Hocko <mhocko@suse.com>,
        Oscar Salvador <osalvador@suse.de>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Dan Williams <dan.j.williams@intel.com>,
        Pavel Tatashin <pasha.tatashin@soleen.com>
Subject: Re: [PATCH v3] mm/memory_hotplug: Fix try_offline_node()
Message-Id: <20191115160833.beda52bc6f1145bc81960ba7@linux-foundation.org>
In-Reply-To: <20191107195845.b0b3921ea146a60d042a8f64@linux-foundation.org>
References: <20191102120221.7553-1-david@redhat.com>
        <51bdb854-a60e-d076-5dde-38481bf4a4b1@redhat.com>
        <20191107195845.b0b3921ea146a60d042a8f64@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 7 Nov 2019 19:58:45 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:

> On Thu, 7 Nov 2019 00:14:13 +0100 David Hildenbrand <david@redhat.com> wrote:
> 
> > > +	/*
> > > +	 * Especially offline memory blocks might not be spanned by the
> > > +	 * node. They will get spanned by the node once they get onlined.
> > > +	 * However, they link to the node in sysfs and can get onlined later.
> > > +	 */
> > > +	rc = for_each_memory_block(&nid, check_no_memblock_for_node_cb);
> > > +	if (rc)
> > >   		return;
> > > -	}
> > >   
> > >   	if (check_cpu_on_node(pgdat))
> > >   		return;
> > > 
> > 
> > @Andrew, can you queued this one instead of v1 so we can give this some 
> > more testing? Thanks!
> 
> Sure.
> 
> We have a tested-by but no reviewed-by or acked-by :(
> 
> Null pointer derefs are unpopular.  Should we cc:stable?

<Crickets>

I added cc:stable and shall send it upstream unreviewed.