Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andy Duan <fugang.duan@nxp.com>
To:     David Miller <davem@davemloft.net>,
        "hslester96@gmail.com" <hslester96@gmail.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH net v2] net: fec: add a check for CONFIG_PM to
 avoid clock count mis-match
Thread-Topic: [EXT] Re: [PATCH net v2] net: fec: add a check for CONFIG_PM to
 avoid clock count mis-match
Thread-Index: AQHVm/DMOznlKnTJFkKJdT1jxlx3n6eNXN9w
Date:   Sat, 16 Nov 2019 06:57:17 +0000
Message-ID: <VI1PR0402MB3600CE74E0EC86AC97F25026FF730@VI1PR0402MB3600.eurprd04.prod.outlook.com>
References: <20191112112830.27561-1-hslester96@gmail.com>
 <20191115.121050.591805779332799354.davem@davemloft.net>
In-Reply-To: <20191115.121050.591805779332799354.davem@davemloft.net>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d03fdd2-dedb-4c88-0ee8-08d76a6237eb
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2019 06:57:17.1256
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PEk7fjF2PU/r6Nk8iPw7L7oe6fXrQzZAsgrOA/gABMb0GUYeSVuGDv8otozxRw2hNjcIjxbQII+rVLaOYDQD7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3951
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: David Miller <davem@davemloft.net> Sent: Saturday, November 16, 2019 =
4:11 AM
> From: Chuhong Yuan <hslester96@gmail.com>
> Date: Tue, 12 Nov 2019 19:28:30 +0800
>=20
> > If CONFIG_PM is enabled, runtime pm will work and call runtime_suspend
> > automatically to disable clks.
> > Therefore, remove only needs to disable clks when CONFIG_PM is disabled=
.
> > Add this check to avoid clock count mis-match caused by double-disable.
> >
> > Fixes: c43eab3eddb4 ("net: fec: add missed clk_disable_unprepare in
> > remove")
> > Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
>=20
> Your explanation in your reply to my feedback still doesn't explain the
> situation to me.
>=20
> For every clock enable done during probe, there must be a matching clock
> disable during remove.
>=20
> Period.
>=20
> There is no CONFIG_PM guarding the clock enables during probe in this dri=
ver,
> therefore there should be no reason to require CONFIG_PM guards to the
> clock disables during the remove method,
>=20
> You have to explain clearly, and in detail, why my logic and analysis of =
this
> situation is not correct.
>=20
> And when you do so, you will need to add those important details to the
> commit message of this change and submit a v3.
>=20
> Thank you.

I agree with David. Below fixes is more reasonable.
Chuhong, if there has no voice about below fixes, you can submit v3 later.

@@ -3636,6 +3636,11 @@ fec_drv_remove(struct platform_device *pdev)
        struct net_device *ndev =3D platform_get_drvdata(pdev);
        struct fec_enet_private *fep =3D netdev_priv(ndev);
        struct device_node *np =3D pdev->dev.of_node;
+       int ret;
+
+       ret =3D pm_runtime_get_sync(&pdev->dev);
+       if (ret < 0)
+               return ret;

        cancel_work_sync(&fep->tx_timeout_work);
        fec_ptp_stop(pdev);
@@ -3643,15 +3648,17 @@ fec_drv_remove(struct platform_device *pdev)
        fec_enet_mii_remove(fep);
        if (fep->reg_phy)
                regulator_disable(fep->reg_phy);
-       pm_runtime_put(&pdev->dev);
-       pm_runtime_disable(&pdev->dev);
-       clk_disable_unprepare(fep->clk_ahb);
-       clk_disable_unprepare(fep->clk_ipg);
+
        if (of_phy_is_fixed_link(np))
                of_phy_deregister_fixed_link(np);
        of_node_put(fep->phy_node);
        free_netdev(ndev);

+       clk_disable_unprepare(fep->clk_ahb);
+       clk_disable_unprepare(fep->clk_ipg);
+       pm_runtime_put_noidle(&pdev->dev);
+       pm_runtime_disable(&pdev->dev);
+
        return 0;
 }

Regards,
Fugang Duan