Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp509170ybc; Sat, 16 Nov 2019 03:39:54 -0800 (PST) X-Google-Smtp-Source: APXvYqwgdUuJtQ1Aaz3TcI9JdOCFMV5MiV/WCr+e3Y1gI8MY+Hgf+Rnl1vEBgwX1O1wr5X2gmUiD X-Received: by 2002:a17:906:245b:: with SMTP id a27mr9319034ejb.192.1573904394081; Sat, 16 Nov 2019 03:39:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573904394; cv=none; d=google.com; s=arc-20160816; b=H7GRISbP93pEBRIezaa3Bua+01NTDBYOVQCumJpEInbiryjekcUrjjnNx61sD7JB+L 7uFnkFaZUuB7h3IlcnGsYm/QX52D5PIP/ubf/pPUVoLNNkS/ZXcLrF80CMg8C3Zie3os mb8r7YLFFz94y0jBvWcBCNOMXQOWFxvFZ6jS2a5bqEaDt7AtqAwZ6FGkHDHaCve6SWk0 YxMFvkeWi1yxkdGP0OaMISnk+BIc4q4Wei4CN3XtNdUE5K1o1QV5JWCuXlqYFxXhS7YS CxtN9oSvaMsM5AWMP2RA+yfikYdqjrCoFoRc4RSN8maV9obP1BevX33dy1QKkqjey9ag 4+JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=yp2MOuYlWvrzqYPv20++/ypoPejCrWy/7b6hc6GvbOM=; b=uYyyg+RcXs3rG8LOlbr530fpuXIyxKjvltEh8kBxXgmLk9Zc1DlOXIsegQU4VZTJME JkjX+aytfNl3mS2eoEU7kvwYHbX88fGrOi6Hn/wNDFBwSko8Qih+JZaM0oj+4wfH5iPX d5z+u5uybKWkkZ3wU9f1LXreJiTOH79jn6zgRBOy0dRBPOLkbOls6KjMyTGOYCl/QRqo NXAavM5+xb3iuvwh9lrOI9u1GQIPBLyyt2o4bUFoB49eNrQqkdfvpS0pM9mC0XOp3fS5 arwdMGTpa81fV3O403wg+cgosO52PLFprbA+MckSAyYocb+9UhTNp4X1a1V9Fk6/w4tc vgWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b15si7766113ejv.167.2019.11.16.03.39.28; Sat, 16 Nov 2019 03:39:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727517AbfKPLht (ORCPT + 99 others); Sat, 16 Nov 2019 06:37:49 -0500 Received: from smtpq3.tb.mail.iss.as9143.net ([212.54.42.166]:43306 "EHLO smtpq3.tb.mail.iss.as9143.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726794AbfKPLht (ORCPT ); Sat, 16 Nov 2019 06:37:49 -0500 X-Greylist: delayed 1201 seconds by postgrey-1.27 at vger.kernel.org; Sat, 16 Nov 2019 06:37:48 EST Received: from [212.54.42.137] (helo=smtp6.tb.mail.iss.as9143.net) by smtpq3.tb.mail.iss.as9143.net with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iVw5K-0001uT-Ao; Sat, 16 Nov 2019 12:17:46 +0100 Received: from mail-wr1-f49.google.com ([209.85.221.49]) by smtp6.tb.mail.iss.as9143.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1iVw5K-0002In-6g; Sat, 16 Nov 2019 12:17:46 +0100 Received: by mail-wr1-f49.google.com with SMTP id z10so13713397wrs.12; Sat, 16 Nov 2019 03:17:46 -0800 (PST) X-Gm-Message-State: APjAAAUdkn0Ngv2jDyck1lAK/7xwHBF07YKWZrVL97tedxHaaE18o93m 5nO044Czncv3fD/U4jZTj6tCLi6DTZJ5/CdXB3g= X-Received: by 2002:a05:6000:14a:: with SMTP id r10mr9800680wrx.310.1573903065942; Sat, 16 Nov 2019 03:17:45 -0800 (PST) MIME-Version: 1.0 References: <20191116110548.8562-1-jongk@linux-m68k.org> In-Reply-To: <20191116110548.8562-1-jongk@linux-m68k.org> From: Kars de Jong Date: Sat, 16 Nov 2019 12:17:34 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] rtc: msm6242: Fix reading of 10-hour digit To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Content-Type: text/plain; charset="UTF-8" X-SourceIP: 209.85.221.49 X-Authenticated-Sender: karsdejong@home.nl (via SMTP) X-Ziggo-spambar: / X-Ziggo-spamscore: 0.0 X-Ziggo-spamreport: CMAE Analysis: v=2.3 cv=WMwBoUkR c=1 sm=1 tr=0 a=9+rZDBEiDlHhcck0kWbJtElFXBc=:19 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=MeAgGD-zjQ4A:10 a=tBb2bbeoAAAA:8 a=b38HSYhmjrW_fiXeJ8EA:9 a=QEXdDO2ut3YA:10 a=Oj-tNtZlA1e06AYgeCfH:22 X-Ziggo-Spam-Status: No X-Spam-Status: No X-Spam-Flag: No Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Forgot to add: Fixes: 4f9b9bba1dd1 ("rtc: Add an RTC driver for the Oki MSM6242") Op za 16 nov. 2019 om 12:06 schreef Kars de Jong : > > The driver was reading the wrong register as the 10-hour digit due to > a misplaced ')'. It was in fact reading the 1-second digit register due > to this bug. > > Also remove the use of a magic number for the hour mask and use the define > for it which was already present. > > Cc: Geert Uytterhoeven > Tested-by: Kars de Jong > Signed-off-by: Kars de Jong