Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Winkler, Tomas" <tomas.winkler@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     "Usyskin, Alexander" <alexander.usyskin@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [char-misc-next] mei: bus: add more client attributes to sysfs
Thread-Topic: [char-misc-next] mei: bus: add more client attributes to sysfs
Thread-Index: AQHVnHIYaV4WCqSUt0SW8MHHb8kk8aeNj+AAgAAieMA=
Date:   Sat, 16 Nov 2019 12:08:52 +0000
Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9DD16447@hasmsx108.ger.corp.intel.com>
References: <20191116142136.17535-1-tomas.winkler@intel.com>
 <20191116115824.GB425445@kroah.com>
In-Reply-To: <20191116115824.GB425445@kroah.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> 
> On Sat, Nov 16, 2019 at 04:21:36PM +0200, Tomas Winkler wrote:
> > From: Alexander Usyskin <alexander.usyskin@intel.com>
> >
> > Export more client attributes via sysfs that are usually obtained upon
> > connection. In some cases, for example a monitoring application may
> > wish to know the attributes without actually performing the connection.
> > Added attributes:
> > max number of connections, fixed address, max message length.
> >
> > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > ---
> >  Documentation/ABI/testing/sysfs-bus-mei | 21 +++++++++++++++
> >  drivers/misc/mei/bus.c                  | 33 +++++++++++++++++++++++
> >  drivers/misc/mei/client.h               | 36 +++++++++++++++++++++++++
> >  3 files changed, 90 insertions(+)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-bus-mei
> > b/Documentation/ABI/testing/sysfs-bus-mei
> > index 3f8701e8fa24..3d37e2796d5a 100644
> > --- a/Documentation/ABI/testing/sysfs-bus-mei
> > +++ b/Documentation/ABI/testing/sysfs-bus-mei
> > @@ -26,3 +26,24 @@ KernelVersion:	4.3
> >  Contact:	Tomas Winkler <tomas.winkler@intel.com>
> >  Description:	Stores mei client protocol version
> >  		Format: %d
> > +
> > +What:		/sys/bus/mei/devices/.../max_conn
> > +Date:		Nov 2019
> > +KernelVersion:	5.5
> > +Contact:	Tomas Winkler <tomas.winkler@intel.com>
> > +Description:	Stores mei client maximum number of connections
> > +		Format: %d
> > +
> > +What:		/sys/bus/mei/devices/.../fixed
> > +Date:		Nov 2019
> > +KernelVersion:	5.5
> > +Contact:	Tomas Winkler <tomas.winkler@intel.com>
> > +Description:	Stores mei client fixed address, if any
> > +		Format: %d
> > +
> > +What:		/sys/bus/mei/devices/.../max_len
> > +Date:		Nov 2019
> > +KernelVersion:	5.5
> > +Contact:	Tomas Winkler <tomas.winkler@intel.com>
> > +Description:	Stores mei client maximum message length
> > +		Format: %d
> > diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index
> > 53bb394ccba6..a0a495c95e3c 100644
> > --- a/drivers/misc/mei/bus.c
> > +++ b/drivers/misc/mei/bus.c
> > @@ -791,11 +791,44 @@ static ssize_t modalias_show(struct device *dev,
> > struct device_attribute *a,  }  static DEVICE_ATTR_RO(modalias);
> >
> > +static ssize_t max_conn_show(struct device *dev, struct device_attribute
> *a,
> > +			     char *buf)
> > +{
> > +	struct mei_cl_device *cldev = to_mei_cl_device(dev);
> > +	u8 maxconn = mei_me_cl_max_conn(cldev->me_cl);
> > +
> > +	return scnprintf(buf, PAGE_SIZE, "%d", maxconn);
> 
> Nit, you can just do sprintf() for sysfs file attributes as you "know"
> the buffer is big enough and your variable will fit.
> 
> Not a bit deal, but something to do in the future.


Right, missed that, I can fix it in a follow up patch or resend this one.
Thanks
Tomas