Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp617294ybc; Sat, 16 Nov 2019 05:43:24 -0800 (PST) X-Google-Smtp-Source: APXvYqyZraK7sJl3ruTdjZx8K4Gyvr65jGcac2z8MrGyDBq1qv8Gce/wxSUrjTUkXbWpiF88AVha X-Received: by 2002:a17:906:234e:: with SMTP id m14mr9587385eja.94.1573911804809; Sat, 16 Nov 2019 05:43:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573911804; cv=none; d=google.com; s=arc-20160816; b=iFNb8MxXDl4pGhG/G6tXec7PBPIp8i+zBjbjV6x6Tx/U5HL7WH5iJgwGmvAJTzihhz vHg/+Tvv1aPyPqfX1VTGyzNY25i6KzSp0WTZE/mHFn2B9EpGhP6pYE8Vam2yWWvCoIPA iE0aqgjUZfSrfddJ45qdcLPUvb5WzwstcAWHziSdtxncm3yPCyFl7zpJxuCT28Tmn1FC dUGKc7l/wnkHpnZoGYIogv+6Kid9kXNue8ToiDotOFQzQfDPz6bH+bhCQRUWlAuXL14x ggQKAuoDtwhid1lGQtZ+4fkRegMlkRCpaHzyiy+XzysMHjAtfh8ZPk6gZql8qyjJMNxG B0TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Eo6rKMiLXm7RuTWNeDXx3kxxbiQjnNCGwxwQyqmQMvI=; b=lMUlhuNbmns0tannb+hK9MjWHd+Mg3rH+GMBGbbI+7EtBW3SwdH57BL8sJTGL59FtE sTLnmrYnP7SxGcAgqcvJg/ln3B0MXVA8Rh1oa+N3YVbOPf3CDVfDq/34XMBfoqZpAVnv LTZN9OHIbqDIkz2PY8PKFQ6WHaiwRqa++8nYkocUJlZ24gTNzfmOvJbF1Yh8S+UQMtmL F+cDGjJmoecFG5c9xzA6YglSsyDZYkzdspVC4Ob+zJr27nBEcBah+Yveu6Bkah0sQn7F 4Vl/T5NVPxD/bQb0nXSaaaXvdtx69wVa0qObS+Wh/tdiv74WZ3FsYwDKQrqLRmyciJWg 0HVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jcXxsQB6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k24si7874387ejv.111.2019.11.16.05.42.59; Sat, 16 Nov 2019 05:43:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jcXxsQB6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727647AbfKPNix (ORCPT + 99 others); Sat, 16 Nov 2019 08:38:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:49370 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727550AbfKPNiw (ORCPT ); Sat, 16 Nov 2019 08:38:52 -0500 Received: from localhost (unknown [84.241.192.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A1EB0206D4; Sat, 16 Nov 2019 13:38:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573911532; bh=gci994AaOD042gwx45qSUayCaGQNJRTbBIZw0AMtQgE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jcXxsQB66dHaomQQGlWE97weyHvZ5fH+lVWQ1XN2jYqReLmDo8u3RY9kE9tni2Ugo /jMGz6bh/o/QH2Rmms8QJyqWxfuPa1HkV3LVHPQPTHNTbJ0SMeQC2a4QNY19Y62ZlL YFOeA+gS+3r1nUHYI7rKeO+YJeWTZs6pHLHsgv9o= Date: Sat, 16 Nov 2019 14:38:49 +0100 From: Greg Kroah-Hartman To: patrick.rudolph@9elements.com Cc: linux-kernel@vger.kernel.org, coreboot@coreboot.org, Allison Randal , Thomas Gleixner , Alexios Zavras , Arthur Heymans Subject: Re: [PATCH 1/3] firmware: google: Release devices before unregistering the bus Message-ID: <20191116133849.GC454551@kroah.com> References: <20191115134842.17013-1-patrick.rudolph@9elements.com> <20191115134842.17013-2-patrick.rudolph@9elements.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191115134842.17013-2-patrick.rudolph@9elements.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 15, 2019 at 02:48:37PM +0100, patrick.rudolph@9elements.com wrote: > From: Patrick Rudolph > > Fix a bug where the kernel module can't be loaded after it has been > unloaded as the devices are still present and conflicting with the > to be created coreboot devices. > > Signed-off-by: Patrick Rudolph > --- > drivers/firmware/google/coreboot_table.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/firmware/google/coreboot_table.c b/drivers/firmware/google/coreboot_table.c > index 8d132e4f008a..88c6545bebf4 100644 > --- a/drivers/firmware/google/coreboot_table.c > +++ b/drivers/firmware/google/coreboot_table.c > @@ -163,8 +163,14 @@ static int coreboot_table_probe(struct platform_device *pdev) > return ret; > } > > +static int __cb_dev_unregister(struct device *dev, void *dummy) > +{ > + device_unregister(dev); Did you build this patch??? Did it work when you tested it? How? Please fix up, greg k-h