Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp704272ybc; Sat, 16 Nov 2019 07:15:15 -0800 (PST) X-Google-Smtp-Source: APXvYqyHGcVTgnNNDtt3ta3BCuxqFVlOC8oqMuO2wmmATaZPQ80q/n4DrEj3TcXQQ6wlqQcL0xjl X-Received: by 2002:a17:907:2078:: with SMTP id qp24mr10401509ejb.157.1573917315213; Sat, 16 Nov 2019 07:15:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573917315; cv=none; d=google.com; s=arc-20160816; b=WS7qP6SvpS1sJcdNteWQVibxjPYhFU/kpsfPX03tmSJqDnLIYsGzWIhQ+oLamXvq6D KJcuKWIC7AJ3x7ikLiUnioYuyQ3e/IDCaifOBpeDRwBmNUmiKTAakIVlpEDSuxiLjoIa iL6wTsSSl4hs/s4NvR1sLwDD0qGpWgd+l5kb5WMKihGo4//22uBGVwQFsC9UFYgiE+Fc SmDVsjpO0s0/ejvJ84vIjolL8E7H4w7nTQs+89Tk3qFqr+enx0dqXlS3UUOvnUcf0iab gEsvb01lzs71B9+VUS+DZpBxNwHj5u+LV9LBaTDj+0bDqr5vfgny4BZKv5PL1rXIt6U9 dt8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=1NR0lZBfSAsF9PTcWhdjtOR0vndWuNhvYIvZ0O6q/gY=; b=cm76Jsmid/rLCS/ej/AYfHdT0w+MkE0eyxeebixuw9A2UyCAYWeYYL7NoKwjrh35sl nxRP4oQguRXpTiyqG2CPDPWA+0/SSSLI+6VQmXRWVrt1uezNbAPQ5BBO0x2+eIowEMPU raAHhZRbcJESHRbFdTyt4UCGVAePfOup4VIWU7tQu50NjAM7NJ+yJ7gksq4fx93Jfu3n CiPxZkNxGUjpM+Tq8BsBEeDofE9E3n1HCW3NMFriGyHiEf87+Z0MwQ7UCi0CRuN8NQw/ EbKXQuQFl1cMwKi5eibnicJmnJuJLYg/deTxblwuckrbNKN51qd/DV1NkRnrPVCG4a+p WeJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=t2Fixbx8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o25si7778209eja.316.2019.11.16.07.14.49; Sat, 16 Nov 2019 07:15:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=t2Fixbx8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727771AbfKPPN3 (ORCPT + 99 others); Sat, 16 Nov 2019 10:13:29 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:41220 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727646AbfKPPN3 (ORCPT ); Sat, 16 Nov 2019 10:13:29 -0500 Received: by mail-pg1-f195.google.com with SMTP id 207so917pge.8; Sat, 16 Nov 2019 07:13:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1NR0lZBfSAsF9PTcWhdjtOR0vndWuNhvYIvZ0O6q/gY=; b=t2Fixbx8FrbucKGgmC0xyNorjg8XHYcKKOvOb8d4MqBkw4RSLbRua9PFBL0WqPxO0S vzDvoPgs9fsNawm1/nDoQKxbYxRICBGkFkcfS7fuYJaPFxrncKHsrBhSmQ0NoZs00GtC XPESdybY3jw3R/zj4Y2fTrDBHkIufqP6WxPogUcFDZKmSox1lRiVh9GXFryLXUCs1Fba +isMDFrscgXvX88Oib81T5jkgiraCTz5X8H9n3iKvL4VsT+dCUtFHaL1v0CAqwMfnEmH RpTXmNjRo4JByPO7ElefkJDkchq5mfKDrHCresVem8NOzbla+YCV+OIMM7J8v8VK/fJY umnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1NR0lZBfSAsF9PTcWhdjtOR0vndWuNhvYIvZ0O6q/gY=; b=BDyqXegdY0MEHePyupPTKv+YCDpOtVdiTdZkeknnV4gAk1snbuDfV9tCJZUwDAvtfZ Rn1iLDEG/hdVYBAprawY80EEJKAu7bh3Qt5DSE6/253UgIj1HJCbpSpX87lNs1OKh13u 7zfAu1HBo+e+qzHvYC7IArpEglKMvpkGuPeWEkiSEGKw2KEAjSziOC/cp2QCPFOvv/X4 AHG6YCmOvu4A8FcmMt6NnbPDEWyjpkOHqYAqkuNYdmDFg/oQgy4kp58eNSzaCVXLfNOF 0EN1Ecf3nmZgy2xKShLpEMo9S7jPq0FmF6SRWCZZZ5i8LJbU3mAxplIndJhF391OWU9J A9RA== X-Gm-Message-State: APjAAAVtpvoE7S3rvsHypjpblb3j303ly9dZaBSJSOXepabgVxFkFPJf CddjkcdS1jJfjoiVZImxUCE= X-Received: by 2002:a63:ea17:: with SMTP id c23mr22941078pgi.85.1573917207501; Sat, 16 Nov 2019 07:13:27 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id m6sm7250201pgl.42.2019.11.16.07.13.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Nov 2019 07:13:26 -0800 (PST) From: Chuhong Yuan Cc: Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] video: fbdev: vesafb: add missed release_region Date: Sat, 16 Nov 2019 23:13:18 +0800 Message-Id: <20191116151318.17874-1-hslester96@gmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver calls request_region in probe but forgets to call release_region in probe failure and remove. Add the missed calls to fix it. Signed-off-by: Chuhong Yuan --- drivers/video/fbdev/vesafb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/vesafb.c b/drivers/video/fbdev/vesafb.c index d9c08f6c2155..fbb196a8bbf6 100644 --- a/drivers/video/fbdev/vesafb.c +++ b/drivers/video/fbdev/vesafb.c @@ -468,6 +468,7 @@ static int vesafb_probe(struct platform_device *dev) fb_info(info, "%s frame buffer device\n", info->fix.id); return 0; err: + release_region(0x3c0, 32); arch_phys_wc_del(par->wc_cookie); if (info->screen_base) iounmap(info->screen_base); @@ -480,6 +481,7 @@ static int vesafb_remove(struct platform_device *pdev) { struct fb_info *info = platform_get_drvdata(pdev); + release_region(0x3c0, 32); unregister_framebuffer(info); framebuffer_release(info); -- 2.24.0