Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp731231ybc; Sat, 16 Nov 2019 07:43:26 -0800 (PST) X-Google-Smtp-Source: APXvYqxQMcKgKf8MCPW220saM6bwjp90Y8Qi2VMzo3p7gOS+3G6js7+5QTSWK/FqVaBP7xgYqsNz X-Received: by 2002:a17:907:4300:: with SMTP id oa24mr10644343ejb.8.1573919006531; Sat, 16 Nov 2019 07:43:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573919006; cv=none; d=google.com; s=arc-20160816; b=g1KDqFkqrHpnBTsVKpZPLZhUBa1Q+OWxSQu5brGe0nC/QkmmBeR2iZ2p/6cQnTF+cK VsO3CZaY1We5sz1OKdMGLURlD0yS2H6nFOt0Da1hvF7jOwZcesbSAT+n3j3wN5K7dXI6 g9VL71x/1MAjgR6NSmLaM7dLkrf397bwpUoiYg2/e03AIsiRm47ke5/2tfj8JGBRHKX0 AMDNNpOcO259V7iArbgqSyDiDFkpvHJYxWlZN8wjsdMxiqf62J2XSwbwq2r8d1giWbhH oXzV8qQmp2vnlXdW2CTMyFhE22xoIqGsXGkMkV2Lwpt7ULf9tE53bmSzGcl/mkaVAmvM 7iGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VEKGgHp31BwUzSb8eAWUVoS3BTB4RoOrBxcAtMsyaPQ=; b=vxbP0liaaiANIfGmC1zgb/KIqTlGDQhb5cbsZf8p7XVfHw7o0zeR03joPX5QkQOlup gYIQfyF8rD3lOA54WYukwTKiJKyde6w8mfAfxPR9wN5qaq7v0WtS2IKkXFc3Y4V2ufGl qNkufyG/DslXmPab1M3vjU0IQDR6Yr/BbKvbqeD7x/y9TaB+EFLyHODJqHOzNq4+fYbr 53WTj+D6mJ2ne2tCbvbTbx6vBVbnvvAJEpj5DYWIzVUkWMLf7uJraF55G/bb9oJccEMV MWItp0VmiuLR+mWN1dAmIu5acPNBVNAwWpJ0+fNZyT9/5DJhBIyO/i4AToboEYkZ+U+s gI3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cD5n6WiI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f13si9302642eda.288.2019.11.16.07.43.02; Sat, 16 Nov 2019 07:43:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cD5n6WiI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727986AbfKPPlm (ORCPT + 99 others); Sat, 16 Nov 2019 10:41:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:44792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727936AbfKPPlg (ORCPT ); Sat, 16 Nov 2019 10:41:36 -0500 Received: from sasha-vm.mshome.net (unknown [50.234.116.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A70A4207DD; Sat, 16 Nov 2019 15:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573918895; bh=E+336G3Zqyz4BvpRIJ6RtfyKVtr1OG5s4I4J4q3nsHU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cD5n6WiIpdPxpzfOas/t0IroVOt3FjnM7I4GDkYdb0JBoT+xuBqMqzpK8Pq0xpSD+ hjTK/eop/S0ZRma6hZK1pZEUdyrdfhTNjpkduZEvPZwABaRQHQP3WnAN2Xx5jOo++q +xGVoZteJIzVjuK4JwCSM4+Ywmf0mh99sdrhi2iw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jens Axboe , Sasha Levin , linux-block@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 021/237] skd: fixup usage of legacy IO API Date: Sat, 16 Nov 2019 10:37:36 -0500 Message-Id: <20191116154113.7417-21-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191116154113.7417-1-sashal@kernel.org> References: <20191116154113.7417-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jens Axboe [ Upstream commit 6d1f9dfde7343c4ebfb8f84dcb333af571bb3b22 ] We need to be using the mq variant of request requeue here. Fixes: ca33dd92968b ("skd: Convert to blk-mq") Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/skd_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 87b9e7fbf0621..27323fa23997d 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -1416,7 +1416,7 @@ static void skd_resolve_req_exception(struct skd_device *skdev, case SKD_CHECK_STATUS_BUSY_IMMINENT: skd_log_skreq(skdev, skreq, "retry(busy)"); - blk_requeue_request(skdev->queue, req); + blk_mq_requeue_request(req, true); dev_info(&skdev->pdev->dev, "drive BUSY imminent\n"); skdev->state = SKD_DRVR_STATE_BUSY_IMMINENT; skdev->timer_countdown = SKD_TIMER_MINUTES(20); @@ -1426,7 +1426,7 @@ static void skd_resolve_req_exception(struct skd_device *skdev, case SKD_CHECK_STATUS_REQUEUE_REQUEST: if ((unsigned long) ++req->special < SKD_MAX_RETRIES) { skd_log_skreq(skdev, skreq, "retry"); - blk_requeue_request(skdev->queue, req); + blk_mq_requeue_request(req, true); break; } /* fall through */ -- 2.20.1