Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 16 Nov 2019 16:59:45 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Giovanni Mascellani <gio@debian.org>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dell-smm-hwmon: Add support for disabling automatic
 BIOS fan control
Message-ID: <20191116155945.tivygva3rbbdolgz@pali>
References: <20191116140649.114592-1-gio@debian.org>
 <20191116145845.xmhki3ckza26eoln@pali>
 <7bc8ec9a-f559-96c8-36fd-6e11a1420626@roeck-us.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="flg5b24ackzt24u5"
Content-Disposition: inline
In-Reply-To: <7bc8ec9a-f559-96c8-36fd-6e11a1420626@roeck-us.net>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--flg5b24ackzt24u5
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Saturday 16 November 2019 07:53:10 Guenter Roeck wrote:
> On 11/16/19 6:58 AM, Pali Roh=C3=A1r wrote:
> > On Saturday 16 November 2019 15:06:49 Giovanni Mascellani wrote:
> > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-=
hwmon.c
> > > index 4212d022d253..67b8c0adede8 100644
> > > --- a/drivers/hwmon/dell-smm-hwmon.c
> > > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > > @@ -68,6 +68,8 @@ static uint i8k_pwm_mult;
> > >   static uint i8k_fan_max =3D I8K_FAN_HIGH;
> > >   static bool disallow_fan_type_call;
> > >   static bool disallow_fan_support;
> > > +static unsigned int smm_manual_fan;
> > > +static unsigned int smm_auto_fan;
>=20
> The "smm_" prefix does not have any value here.

These variables store SMM command numbers and seems that in this patch
they were converted from macros "#define I8K_SMM_MANUAL_FAN	0x34a3"

--=20
Pali Roh=C3=A1r
pali.rohar@gmail.com

--flg5b24ackzt24u5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQS4VrIQdKium2krgIWL8Mk9A+RDUgUCXdAc7wAKCRCL8Mk9A+RD
UsfEAJoDKRkxM6QIFvf1qBY9lV2BcXUc7wCgzBCg1avUGdNJmdcQX1Q7gmPz7Sk=
=J3Ov
-----END PGP SIGNATURE-----

--flg5b24ackzt24u5--