Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp766345ybc; Sat, 16 Nov 2019 08:19:08 -0800 (PST) X-Google-Smtp-Source: APXvYqylank1RZYInFhe1YQUu4gT9G2umVlzPTkZb0wNcCTr2NaaOrqAVD+qIOD70Vdc7ZVmWrAz X-Received: by 2002:a17:906:938c:: with SMTP id l12mr10768410ejx.135.1573921147949; Sat, 16 Nov 2019 08:19:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573921147; cv=none; d=google.com; s=arc-20160816; b=wxdaAVZ567r1xOsIl8AkVv8B49dt7LDwtC+3+w3D+l9g9hExkB5ZdOeu2rt9SNCcWK ZGtZrHjISAn5lZevUq8PmDi2UNV8+cETq0gQ4CfsKYpWaesjHRhuP6wRMn9kos7TfZAA gaN8u7pqZzdNvkpVuHia3oopcnSkoYsKUttUXth1DcjtQ91Qmqmhg+nj2ghMSKznp8ml OG9p/NBIfMJ7lIUm8yrrsbgbfGHxTY5EPR1h3PDk8iNXPTDNGn/HALzsGdG3/AxDjhP7 KUXjJN2DtvOr/yRbLb59/Q0GRt/aRtzK0zcxvhjMJjZWhHRFm0FLsHD8aYPPyUZ/XPxu mO/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mOGJbKvtznptc16N8i9RH2odNgFC+jlFXEfrV0Wr8Fc=; b=0NAgnkSDo+kNM43otN4N78yTrTFmwM5J7vdLq7O59zDzlVPOWRzSxkDt3zaNPLHdo5 IiA4kFPzYVzEg+ovx8Q8YSc2OzVahJNkUAnjADc+OPBZteehWz9Dg7OYstwSvLOoZPQB JFDgO00Uq01eccz7C37vb4oV7v2yMRVZAgqFIZGThkDM4wqliVSPDuamk6KIMzx9Y8vr 4ttrU0QDn9/RPwpBwaWMe9AyjsxlmS5zfbLwd/U7uNZpUgBWwakSqLpuKLYYQdibA5aV rTa01WZUNcMiYZJV5Utbw57XBSnHcFuHmW56i1sJ6cPkYpvOEjVWxe81l3ceSqOYNUxe THCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oA3jqOl4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c36si9148757edb.58.2019.11.16.08.18.42; Sat, 16 Nov 2019 08:19:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oA3jqOl4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729641AbfKPPrJ (ORCPT + 99 others); Sat, 16 Nov 2019 10:47:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:53028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729445AbfKPPqh (ORCPT ); Sat, 16 Nov 2019 10:46:37 -0500 Received: from sasha-vm.mshome.net (unknown [50.234.116.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2C44A2084E; Sat, 16 Nov 2019 15:46:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573919196; bh=/qskU+Rb0nZDn2tSBNtS2ClPWcweMC/WHlCVXemRU+M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oA3jqOl4+3YnaSIJ30E+THgBtmlALltw+E93LkJjBml2cLHq60Whg/UEebsFCFBUN J+5K4Z05hSel1TBjZsFc7/IFJrS1WSqIyBGfxOYvBSExsTLqmc78n9dpZwdW0OLAKb Iufxan+0hkrYa2yUPWlGD3RQ1XfdKycwaIvJYtBQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ali MJ Al-Nasrawy , Kalle Valo , Sasha Levin , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 203/237] brcmsmac: never log "tid x is not agg'able" by default Date: Sat, 16 Nov 2019 10:40:38 -0500 Message-Id: <20191116154113.7417-203-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191116154113.7417-1-sashal@kernel.org> References: <20191116154113.7417-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ali MJ Al-Nasrawy [ Upstream commit 96fca788e5788b7ea3b0050eb35a343637e0a465 ] This message greatly spams the log under heavy Tx of frames with BK access class which is especially true when operating as AP. It is also not informative as the "agg'ablity" of TIDs are set once and never change. Fix this by logging only in debug mode. Signed-off-by: Ali MJ Al-Nasrawy Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- .../net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c index 23118207b661e..9657b992f90e1 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c @@ -846,8 +846,8 @@ brcms_ops_ampdu_action(struct ieee80211_hw *hw, status = brcms_c_aggregatable(wl->wlc, tid); spin_unlock_bh(&wl->lock); if (!status) { - brcms_err(wl->wlc->hw->d11core, - "START: tid %d is not agg\'able\n", tid); + brcms_dbg_ht(wl->wlc->hw->d11core, + "START: tid %d is not agg\'able\n", tid); return -EINVAL; } ieee80211_start_tx_ba_cb_irqsafe(vif, sta->addr, tid); -- 2.20.1