Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp779983ybc; Sat, 16 Nov 2019 08:33:25 -0800 (PST) X-Google-Smtp-Source: APXvYqz/2/Me3dXxpvWUa6t4VhggXxiXW+eII+RsE3JRAZfkP9u6RWt2io5nGL+ECRCK7ax/kFXu X-Received: by 2002:a17:906:f259:: with SMTP id gy25mr10617103ejb.297.1573922005503; Sat, 16 Nov 2019 08:33:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573922005; cv=none; d=google.com; s=arc-20160816; b=b3zLfry1W5MtCpXvo/sDSVHAo2Cf1RhUcG5b4aDgRwnKhwCNtijGv222zg8B066BQl 011doD4xUNl+FMhmKCnacBpsvd5UopMklXEAeq6GowQsWJkLO9rsZs7SVUsVYOTA7rFC mPRtgM6ArAIBkpTMpKwV3Q0/an44Rzl9UADPQVkA1UpgK42OljvlmtgSc33QhQxtUaxn 3BTndlb0qzWNfHJ7TtoGLkqtxWINU6SppBNk0EuCxv5vpxG1xQc5iGimSRXdttS+iDme TJBY9ZUZQcsP9FpA1z2T29piOyNsatifcdWG9L5mN3cYuRVryxdvCnbAnxWEf4Gobvil VEDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1510cbrcAtFvUZ9sa3SWHbzwFpTvi1uSwB1g9Kxd1lQ=; b=aYBQSzpoE4y6m1Vm7bDAj9munxGYVgavlsjTbsNizKLJpPA3TE8k4MHKhjUvXHvpfJ 8wHOMD6jSzgDcXAtblfDcnwXQTCxx3ddUUtYiuRuM2JPOcSjlO9Sz7fmo1svHG1vG2si b9KC54VeSHfgcRZtW5uFIVh+1s7djBct9KxqPubmZILcw2tpOV5JZbGBEDx6++z628Y7 mCA9Xj0U7HQqnOXET8QEkrq6Uevhbmp0Y+znxl//kKDxCmYg5Wlo08W+/ygE2onXUI7R cbgeOz8d+pnzzzAK4OoFavu1j/mfZ0rr3KsRt36QM76oW39nhtBL7UHkgY17MKKjA3Pa fx8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="aG/v/k37"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x70si9752819ede.257.2019.11.16.08.33.01; Sat, 16 Nov 2019 08:33:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="aG/v/k37"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730569AbfKPQ2i (ORCPT + 99 others); Sat, 16 Nov 2019 11:28:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:44266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727606AbfKPPlR (ORCPT ); Sat, 16 Nov 2019 10:41:17 -0500 Received: from sasha-vm.mshome.net (unknown [50.234.116.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4509720748; Sat, 16 Nov 2019 15:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573918877; bh=mdj7XPfQr7aTT3QJ1EjZS6B280N60fbSQCKhLUyoZvw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aG/v/k37iHYzY2OMgE/sUOUGiftiT+KbvfL6/4i7YL5fDv2TvCG1kT28AhiQicBd4 gaZQfb4Lci9ttdYY6D1sbx25lYNikNKj5Elt8KwkbZWztJerIX1EIytIdnBZLBL5Ky jNS35FJf+xIb8S7s13nMjtnHEMCX/6bLdpLiTTDw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alan Douglas , Lorenzo Pieralisi , Sasha Levin , linux-pci@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 006/237] PCI: cadence: Write MSI data with 32bits Date: Sat, 16 Nov 2019 10:37:21 -0500 Message-Id: <20191116154113.7417-6-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191116154113.7417-1-sashal@kernel.org> References: <20191116154113.7417-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alan Douglas [ Upstream commit e81e36a96bb56f243b5ac1d114c37c086761595b ] According to the PCIe specification, although the MSI data is only 16bits, the upper 16bits should be written as 0. Use writel instead of writew when writing the MSI data to the host. Fixes: 37dddf14f1ae ("PCI: cadence: Add EndPoint Controller driver for Cadence PCIe controller") Signed-off-by: Alan Douglas Signed-off-by: Lorenzo Pieralisi Signed-off-by: Sasha Levin --- drivers/pci/controller/pcie-cadence-ep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c index 6692654798d44..c3a088910f48d 100644 --- a/drivers/pci/controller/pcie-cadence-ep.c +++ b/drivers/pci/controller/pcie-cadence-ep.c @@ -355,7 +355,7 @@ static int cdns_pcie_ep_send_msi_irq(struct cdns_pcie_ep *ep, u8 fn, ep->irq_pci_addr = (pci_addr & ~pci_addr_mask); ep->irq_pci_fn = fn; } - writew(data, ep->irq_cpu_addr + (pci_addr & pci_addr_mask)); + writel(data, ep->irq_cpu_addr + (pci_addr & pci_addr_mask)); return 0; } -- 2.20.1