Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191112130510.91570-1-tonylu@linux.alibaba.com>
 <20191112130510.91570-2-tonylu@linux.alibaba.com> <ea3bf073-68af-d899-2664-fef54953a68d@gmail.com>
In-Reply-To: <ea3bf073-68af-d899-2664-fef54953a68d@gmail.com>
From:   Cong Wang <xiyou.wangcong@gmail.com>
Date:   Sat, 16 Nov 2019 11:47:33 -0800
Message-ID: <CAM_iQpW7S9fUX33jCNhRfsK17rGmFSCkO97ujREJGsq1NpwwzQ@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] net: add trace events for net_device refcnt
To:     David Ahern <dsahern@gmail.com>
Cc:     Tony Lu <tonylu@linux.alibaba.com>,
        David Miller <davem@davemloft.net>,
        Eric Dumazet <eric.dumazet@gmail.com>, shemminger@osdl.org,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Nov 12, 2019 at 7:27 AM David Ahern <dsahern@gmail.com> wrote:
> The location alone does nothing for resolving reference count leaks; you
> really have to use stack traces to pair up the hold and put and to give
> context for what are repetitive locations for the hold and put.

+1

And, as you are using tracepoint, you get trace filter and trigger for free,
which already includes stacktrace.