Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp989279ybc; Sat, 16 Nov 2019 12:30:49 -0800 (PST) X-Google-Smtp-Source: APXvYqwY5KS6tNap98Ii/DSovDHi5Ty2nbQ5almx3JOueD/4cS3RvjloXijxkAmK7AbLS8YTbiuy X-Received: by 2002:a17:906:1354:: with SMTP id x20mr12887679ejb.131.1573936249595; Sat, 16 Nov 2019 12:30:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573936249; cv=none; d=google.com; s=arc-20160816; b=Ye1OVb7TxWhpogFVUZ//bo3X1gF6cZaGclCojlK5s894TTkd5nSVbsgaZ96LJ7OH2q KIAVhFwuv/nkIZXmIpKMX7tGjC96aRTJ3HoRKq7l5/eUwwjAFeAxi/gXna3aXGRwqWno yhGnIxWC5KI64YAVJupvgKvzGkKGjc7BgrPMLKXEnYGGW3VRY1H7tj1FRtXddnlN2NIX Z42Yz5ocw70eTjq7RfXThvX+uKp6laKfbujaP3fr9OUA6Okxw+g0gVON22v1QvO5/VL8 gyRs7r1Vbzyp5D53nuRkCtwNFiD1o/YK1qKqReXKFiaUGawU0rjydbAo8vSUprITPZJf l8LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=AlQihQT5oyl2kE930+LF7lWJeqVAtBcGvnjCh4TQ7rc=; b=S6SmDS/rO7SkSkzy8vgPVtNMto3WNsiGweEtsx/n1hxkw7ljRV3VUunh4Ha9xAX5Mq 2+B+OskS5WQ50+DhOD73HWB/hwoTL2TZXK1Q9eqwzMceplQhg/bX91lOwnl7zcQd5Dto o6/NboFaAUdu4eCK0kySozd+1HKuh5sCm13mlSiW2DQCjdZwGkPqUcuvx/kjaYMPJdHd xun79A2PiPrtVZq4qqTIEGckcxP+V4JzSLmd+Ul3kBLShwsdwdF9JiJiGCnKnHCTS6Mn HwFq0OhDVPCKCBFG6x+L8PuWVIX4Y2bVlSda6zaX1yJ0lIJV7Bo8KG3ojRZuOdAjjMhQ Nz+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k10si8496129edx.350.2019.11.16.12.30.12; Sat, 16 Nov 2019 12:30:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727682AbfKPURM (ORCPT + 99 others); Sat, 16 Nov 2019 15:17:12 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:53226 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727115AbfKPURL (ORCPT ); Sat, 16 Nov 2019 15:17:11 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3CA4815172091; Sat, 16 Nov 2019 12:17:11 -0800 (PST) Date: Sat, 16 Nov 2019 12:17:10 -0800 (PST) Message-Id: <20191116.121710.1143094650284471912.davem@davemloft.net> To: hslester96@gmail.com Cc: nicolas.ferre@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] net: macb: add missed tasklet_kill From: David Miller In-Reply-To: <20191116142310.13770-1-hslester96@gmail.com> References: <20191116142310.13770-1-hslester96@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 16 Nov 2019 12:17:11 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan Date: Sat, 16 Nov 2019 22:23:10 +0800 > This driver forgets to kill tasklet in remove. > Add the call to fix it. > > Signed-off-by: Chuhong Yuan > --- > Changes in v2: > - Rebase on net-next. Does this bug exist in mainline? Then this bug fix should target 'net'. You must also provide an appropriate Fixes: tag which indicates the commit which introduced this bug. Thank you.