Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 16 Nov 2019 13:10:58 -0800 (PST)
Message-Id: <20191116.131058.1856199123293908506.davem@davemloft.net>
To:     lrizzo@google.com
Cc:     netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org, tariqt@mellanox.com
Subject: Re: [PATCH] net/mlx4_en: fix mlx4 ethtool -N insertion
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20191115201225.92888-1-lrizzo@google.com>
References: <20191115201225.92888-1-lrizzo@google.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Luigi Rizzo <lrizzo@google.com>
Date: Fri, 15 Nov 2019 12:12:25 -0800

> ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the
> total number of entries in the rx classifier table.  Surprisingly, mlx4
> is missing this part (in principle ethtool could still move forward and
> try the insert).
> 
> Tested: compiled and run command:
> 	phh13:~# ethtool -N eth1 flow-type udp4  queue 4
> 	Added rule with ID 255
> 
> Signed-off-by: Luigi Rizzo <lrizzo@google.com>
> Change-Id: I18a72f08dfcfb6b9f6aa80fbc12d58553e1fda76

Luigi, _always_ CC: the appropriate maintainer when making changes to the
kernel, as per the top-level MAINTAINERS file.

Tariq et al., please review.