Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1072761ybc; Sat, 16 Nov 2019 14:27:05 -0800 (PST) X-Google-Smtp-Source: APXvYqz7VaZoq+xsdnBXBwJIqBqRi6zLhjZx7rEqKmr6bgTsn84e70DyAqplKKHVLAd8oq8KdhgP X-Received: by 2002:a17:907:204b:: with SMTP id pg11mr13416908ejb.119.1573943225393; Sat, 16 Nov 2019 14:27:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573943225; cv=none; d=google.com; s=arc-20160816; b=TjdAjfOif5DcoWVQNNwHWW9ExfcRlN+Dj/WIQswtjODWzbzIF8PkkUtVOBP2NVtAHF CuyMNxfKSpIAGGVOvq0F2K6rDpxukqJHAGhN33YVaY5CF/AdM0bGo+56cG+k0mi2senK CYFRaBrWog+kl7O970ns0iOnRLrqIYO/TkAYCsRlDkFv88HSIcrolU39D2adhvc2nF5w 6nBlIjXxqJjeiKeVKBQz41L/OwZTlknuVVWuJvXGjCqBgnvzVnhU833PW28BPx58gFHb H6MZ4zJhbxQhKFFcQ0vlX/ENAgk/7jiWtRlJrCt+nyj8VWxl4dqGCK5vz4vbFMEFhSba GB1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=0kr0PGCQy0Z97bgHM5LKSHLI8FBQC2icjFwrSq2WjiI=; b=DAx30u+ZTXZtvd3g0UdkJ7Fkx1mHhmlQwssST4WTqV7Ash0UEQHasG7YQi8gGcKdTf xKo4rGu1VZn192A6FIn8pmedb1nbmg5Z8/pEwr6mFL9T6wy8Hun1Kfbm3IixyXU48NYc k//JkWFmjjOMkiMp+F8RRvbTsPDkuSKSkSl6APn4TJNPsJOW4eXYguc59f0s5UeQ0ppl GjHwqbYbBKU6HYk2Yyz8nJ/8VGcljE27lFtDGi+svqpdUJQjhp/pcJt1cc4mPdyWILuJ HIpglBzrrcYFsyLnMLmT7xWgHmjh5u9SrO9NLpdMWOvLPTVTuQ0TiSK8eZDCeRjXSOoh PrDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mcXGJU44; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k10si8646192edx.350.2019.11.16.14.26.26; Sat, 16 Nov 2019 14:27:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mcXGJU44; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727639AbfKPWZE (ORCPT + 99 others); Sat, 16 Nov 2019 17:25:04 -0500 Received: from mail-il1-f196.google.com ([209.85.166.196]:44271 "EHLO mail-il1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727561AbfKPWZE (ORCPT ); Sat, 16 Nov 2019 17:25:04 -0500 Received: by mail-il1-f196.google.com with SMTP id i6so3054721ilr.11; Sat, 16 Nov 2019 14:25:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0kr0PGCQy0Z97bgHM5LKSHLI8FBQC2icjFwrSq2WjiI=; b=mcXGJU44h2VhVUi44c0HCwkZowXeV+SUbiixMSGtj5F+6qlghGFT2Xq8YFIsBM3b6a NB2j5Nvgi1eWjexCryE5t7Z9PFBEjTZgRl7FpG0HVfliudk+t6skWdFnAPAgDsiXWMOD H0JdBXkeu00GGM50LQS1NVVKhOnWS8ae/Gv2n/g36A9sqRAsCeHL6fRqBVCZlqSnrUV8 FulaYnkIh9Bwmvgv/5Tci63+PxwFdYSXlKyq8KcUkvFreu/o0zpqs8zePODC+D0CKMz9 b5YR2yz9gcNrpO6d1aQ+a2KiiT3vYxwjF9WYOBnakvQ0HcBi4oDkRhiL6X57twKT33NO b7Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0kr0PGCQy0Z97bgHM5LKSHLI8FBQC2icjFwrSq2WjiI=; b=fhmey4iga4g1xYAGjSjmS6I2okPwVR2gdPCvewMhZ3ub8jiec3FPhA5/SiWl2nMpOx n8T5nwyc4wjmaxUUCo0382ZuGWoCuF0LaGE/ljLCySd50GUlIMk3eDwgiCL4X5wldyUU ZxEcbtlbH8H3J0hbs8dtjUcDwv7vB4lB0eVh6VqgQDEiMUum0VloN2Lv3R6NwF2Zsst1 5WdN0WvmrCykEvoD1dbYZ3NGX9+6w+N/cU6TBCBeoI5GSQaPEmjEmya2MEScOZV4nzXD 9W9vKvtBwc1Jd2/C4lQ0o1cKJtquuaFbOQKBKICpauLjiBU9CpkuNqlyKNrLm+rHgxFY xajw== X-Gm-Message-State: APjAAAVUKRQxoeAzys7OO2Yyd+PgAJbS+qnjHlz7+QWWvq+W3AvUQxjL 6rTnYEWQEShi+uvMeNbDCt7rX+r3nuPg7gWNQeg= X-Received: by 2002:a05:6e02:c91:: with SMTP id b17mr7894961ile.33.1573943103501; Sat, 16 Nov 2019 14:25:03 -0800 (PST) MIME-Version: 1.0 References: <20191116064415.159899-1-bjorn.andersson@linaro.org> In-Reply-To: <20191116064415.159899-1-bjorn.andersson@linaro.org> From: Jeffrey Hugo Date: Sat, 16 Nov 2019 15:24:52 -0700 Message-ID: Subject: Re: [PATCH] arm64: dts: qcom: msm8998-mtp: Add alias for blsp1_uart3 To: Bjorn Andersson Cc: Andy Gross , MSM , DTML , lkml Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 15, 2019 at 11:44 PM Bjorn Andersson wrote: > > The msm_serial driver uses a simple counter to determine which port to > use when no alias is defined, but there's no logic to prevent this from Which port to use for what, the default console? > not colliding with what's defined by the aliases. As a result either > none or all of the active msm_serial instances must be listed as > aliases. > > Define blsp1_uart3 as "serial1" to mitigate this problem. > > Fixes: 4cffb9f2c700 ("arm64: dts: qcom: msm8998-mtp: Enable bluetooth") > Signed-off-by: Bjorn Andersson That driver behavior seems like a strange thing to be doing. If you clarify the question above, - Reviewed-by: Jeffrey Hugo > --- > arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi > index 5f101a20a20a..e08fcb426bbf 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi > @@ -9,6 +9,7 @@ > / { > aliases { > serial0 = &blsp2_uart1; > + serial1 = &blsp1_uart3; > }; > > chosen { > -- > 2.23.0 >