Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1101992ybc; Sat, 16 Nov 2019 15:07:04 -0800 (PST) X-Google-Smtp-Source: APXvYqzv3hjEqwYuZ47OmCRIdRNC2XyzYaZAUELUFdNIndESyVH0GFBBh3kKIiCybT9j2D+BWtKR X-Received: by 2002:a17:906:301a:: with SMTP id 26mr13467657ejz.201.1573945624003; Sat, 16 Nov 2019 15:07:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573945623; cv=none; d=google.com; s=arc-20160816; b=WUljC/JGRtlBjBuJ+wLqZiRWLjpMNM7iFycoZYRO7/gMYxurJuttBawIWq1OfzyUx6 vxEKaog4sbwlD6+yy5chg1TsrERsvavxjUeMotHIaZ3Chx+OXa3YjB67GaCWZZvm1Vfu vYPPBUoQe+blTlMJTKlhrUsT9CDp0vBJ2McQS3jLGHFQkcFqM5EXOkb2PifgNOt/0TqO GJuzWZkz26pPIJ6Y9REB5Jj1FoOvTZ8BnH/GDRs2rqjeLjBT5mqNXbpfl5Cdqi79JXkl B2Duh9t8CAdfKcISXtNREsw23Vc3P0rkoZRE8mdqJWsk2MIQr0ZSC3S3v7aQoHkv/UjJ ZFuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:message-id :in-reply-to:subject:cc:to:from:date; bh=L2FSpRDwWCfNsXUELEkPiZIQxbiRDOPfm9pTvz7Bl7M=; b=I/D08EcYO/m8+wBZc7wPA9XxEqBxdaee9oARWKqWbfx2jOKc/fOCzHx2/2O/LUB1if 11O5s+fAx0wf8/FA3x+nJn8hFIxycA7f4yvqHWHRF1Wi0M8WOpnq7kjwCMJx/PcDod/w +y4erStasik1rzUN15vbIQARyig1yfQ6kwPH3nLxp2BHoXevd/hYoISmL1PH3BidaBvw n4ZtA04FyAkxq97S422eNmKTZbO4jSf+I1yJSjhrK92l7kGuplkttjhTiANlVw80VzoC p0DS57R5T4eUsR+ea+ZK+SLhIdVpc+Ul0Jeaww0ReRe7YpdAnABS9gRj876iHtjXmdkM wfTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z16si10125655edb.23.2019.11.16.15.06.39; Sat, 16 Nov 2019 15:07:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727717AbfKPXC7 (ORCPT + 99 others); Sat, 16 Nov 2019 18:02:59 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:52816 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727273AbfKPXC6 (ORCPT ); Sat, 16 Nov 2019 18:02:58 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id 875D728EDF; Sat, 16 Nov 2019 18:02:56 -0500 (EST) Date: Sun, 17 Nov 2019 10:02:46 +1100 (AEDT) From: Finn Thain To: Michael Schmitz cc: "James E.J. Bottomley" , "Martin K. Petersen" , Kars de Jong , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] esp_scsi: Clear Transfer Count registers before PIO transfers In-Reply-To: <36712461-b94c-4aff-8664-3896c2cf2524@gmail.com> Message-ID: References: <2bbb6359d542f5882be67c415ecc25ad2d9eeb5e.1573875417.git.fthain@telegraphics.com.au> <36712461-b94c-4aff-8664-3896c2cf2524@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 16 Nov 2019, Michael Schmitz wrote: > > I believe you also need to send a DMA NOP command to the ESP > I believe you're right. I shall add the missing DMA NOP command. Thanks for your review! --