Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 16 Nov 2019 20:41:05 -0500
From:   Brian Masney <masneyb@onstation.org>
To:     Stephen Boyd <sboyd@kernel.org>
Cc:     mturquette@baylibre.com, agross@kernel.org,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org,
        jonathan@marek.ca
Subject: Re: [PATCH] clk: qcom: mmcc8974: move gfx3d_clk_src from the mmcc to
 rpm
Message-ID: <20191117014105.GA13775@onstation.org>
References: <20191115123931.18919-1-masneyb@onstation.org>
 <20191116185457.GA11601@onstation.org>
 <20191117012737.CED5B20730@mail.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191117012737.CED5B20730@mail.kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Nov 16, 2019 at 05:27:36PM -0800, Stephen Boyd wrote:
> Quoting Brian Masney (2019-11-16 10:54:57)
> > > diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c
> > > index bcb0a397ef91..015426262d08 100644
> > > --- a/drivers/clk/qcom/mmcc-msm8974.c
> > > +++ b/drivers/clk/qcom/mmcc-msm8974.c
> > > @@ -2411,7 +2399,6 @@ static struct clk_regmap *mmcc_msm8974_clocks[] = {
> > >       [VFE0_CLK_SRC] = &vfe0_clk_src.clkr,
> > >       [VFE1_CLK_SRC] = &vfe1_clk_src.clkr,
> > >       [MDP_CLK_SRC] = &mdp_clk_src.clkr,
> > > -     [GFX3D_CLK_SRC] = &gfx3d_clk_src.clkr,
> > >       [JPEG0_CLK_SRC] = &jpeg0_clk_src.clkr,
> > >       [JPEG1_CLK_SRC] = &jpeg1_clk_src.clkr,
> > >       [JPEG2_CLK_SRC] = &jpeg2_clk_src.clkr,
> > 
> > I just realized that I also need to remove the GFX3D_CLK_SRC #define
> > from include/dt-bindings/clock/qcom,mmcc-msm8974.h. I'll send out a v2
> > tomorrow evening.
> > 
> 
> Please don't change the binding. In reality the define will never be
> used but also in reality the clk exists, so it's fine to leave it in the
> binding.

OK, that makes sense. Thanks for your help on this.

Brian