Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <60e827cb-2bba-2b7e-55dc-651103e9905f@huawei.com> <20191116.125316.1859622454319892445.davem@davemloft.net>
In-Reply-To: <20191116.125316.1859622454319892445.davem@davemloft.net>
From:   Taehee Yoo <ap420073@gmail.com>
Date:   Sun, 17 Nov 2019 15:17:38 +0900
Message-ID: <CAMArcTWUV1iZuACs0FTwC1jdFYSupPNsaV+9E_HQta1Vdyh6gg@mail.gmail.com>
Subject: Re: [PATCH] vrf: Fix possible NULL pointer oops when delete nic
To:     David Miller <davem@davemloft.net>
Cc:     wangxiaogang3@huawei.com, dsahern@kernel.org, shrijeet@gmail.com,
        Netdev <netdev@vger.kernel.org>, linux-kernel@vger.kernel.org,
        hujunwei4@huawei.com, xuhanbing@huawei.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 17 Nov 2019 at 05:53, David Miller <davem@davemloft.net> wrote:
>

Hi David,
Thank you for Ccing!

> From: "wangxiaogang (F)" <wangxiaogang3@huawei.com>
> Date: Fri, 15 Nov 2019 14:22:56 +0800
>
> > From: XiaoGang Wang <wangxiaogang3@huawei.com>
> >
> > Recently we get a crash when access illegal address (0xc0),
> > which will occasionally appear when deleting a physical NIC with vrf.
> >
> > [166603.826737]hinic 0000:43:00.4 eth-s3: Failed to cycle device eth-s3;
> > route tables might be wrong!
> > .....
> > [166603.828018]WARNING: CPU: 135 PID: 15382at net/core/dev.c:6875
> > __netdev_adjacent_dev_remove.constprop.40+0x1e0/0x1e8
> > ......
>
> Taehee-ssi, please take a look at this.
>
> It is believed that this may be caused by the adjacency fixes you made
> recently.
>

I will take a look at this
Thank you!

> Thank you.