Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: 8LTLXDbACEMr8sqBGd2qIiwPRkh98omGIUogT7MHD0HtMdlm6eKX+x9QSTOzUnU5592+AcQqXQ
 X0PKcKNhF11g==
Subject: Re: [PATCH] net/mlx4_en: fix mlx4 ethtool -N insertion
To:     <lrizzo@google.com>
CC:     David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>,
        <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <tariqt@mellanox.com>
References: <20191115201225.92888-1-lrizzo@google.com>
 <20191116.131058.1856199123293908506.davem@davemloft.net>
From:   Gal Pressman <galpress@amazon.com>
Message-ID: <a26095dd-7fda-72c8-57e1-72da7b8d1b59@amazon.com>
Date:   Sun, 17 Nov 2019 17:28:42 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20191116.131058.1856199123293908506.davem@davemloft.net>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 16/11/2019 23:10, David Miller wrote:
> From: Luigi Rizzo <lrizzo@google.com>
> Date: Fri, 15 Nov 2019 12:12:25 -0800
> 
>> ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the
>> total number of entries in the rx classifier table.  Surprisingly, mlx4
>> is missing this part (in principle ethtool could still move forward and
>> try the insert).
>>
>> Tested: compiled and run command:
>> 	phh13:~# ethtool -N eth1 flow-type udp4  queue 4
>> 	Added rule with ID 255
>>
>> Signed-off-by: Luigi Rizzo <lrizzo@google.com>
>> Change-Id: I18a72f08dfcfb6b9f6aa80fbc12d58553e1fda76
> 
> Luigi, _always_ CC: the appropriate maintainer when making changes to the
> kernel, as per the top-level MAINTAINERS file.

You should also remove the Change-Id tag before submission.