Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1894531ybc; Sun, 17 Nov 2019 09:32:09 -0800 (PST) X-Google-Smtp-Source: APXvYqyBI7iuH3Q8rF6uG4MKYVV7m9YIbI4MKOwASl++oiXz0BNyCLWnzjaCjFY1JOojIBal++YX X-Received: by 2002:a17:906:b80f:: with SMTP id dv15mr20309114ejb.188.1574011929782; Sun, 17 Nov 2019 09:32:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574011929; cv=none; d=google.com; s=arc-20160816; b=DbG/yuHMsyTzNlBGqGxCa+0I/bdO2UhAOddAQvSgWzW6JZCTK7AQYzgsyO2RnpOAU0 Dtw3tabZR3Cfn6SVvWIdTT/ufVMKzw2RMV5A9hpCOulU4kjXg1Y5yZNZyPiZHrs/DgAL fBYWWipiQdJo0kpEiCDyTwxrDfn83jjloFMB48PAjCEfNLSX5wZjllg/qUIJO+Afy9i2 nBcXdF84+yrz4R2aGl8QhblYDlTLOjUAWWb8jRS1wqn06nq7lmx4HLRWRu7LeRR93+Cd Lx/HkjtKSVeD3hTzFP8Mh27sPrKwIWBbqtIzoqG6dztiRdElQ2QUUv5p70llz3rCLqBr dZsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=RIby2qRx5cEwNIrcIoDIHdDJ6ejQhdeyp3owCLM8obk=; b=vdhlZTD1v6ZAayOx8YWl82tUX0I4PdKA0pfrr8frGzy5qAqTfgj3UecW+jQk9xq93A pSxjmkH9cuKbzaY9JF32TDT46JwMZxMSjyjya2xfJlCKThO/tCf3B4VnHtcv8QQSgzX1 Y1rcPxacDW41gmXxlt8kEe4yLfogjsBEvGoGd8AXeOxOKOb1wtXu1DZ+zF5rgL6HhQvP 042DuYFCHwf7VkkgZKu2UW2awzOeU6SHQ5m3KUM+17azDU3uKDflW3lLnCNFWf8y62zf sqHJNmIgDVRQCQTgE0k4sBkhtR4mN8aZFzduQq4yU2DyACr35KlnkykSHR1O5DM3dX2B zVUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=IRanUKst; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id qw23si1707580ejb.1.2019.11.17.09.31.44; Sun, 17 Nov 2019 09:32:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=IRanUKst; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726128AbfKQRai (ORCPT + 99 others); Sun, 17 Nov 2019 12:30:38 -0500 Received: from mta-p6.oit.umn.edu ([134.84.196.206]:60774 "EHLO mta-p6.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726043AbfKQRah (ORCPT ); Sun, 17 Nov 2019 12:30:37 -0500 X-Greylist: delayed 460 seconds by postgrey-1.27 at vger.kernel.org; Sun, 17 Nov 2019 12:30:36 EST Received: from localhost (unknown [127.0.0.1]) by mta-p6.oit.umn.edu (Postfix) with ESMTP id 47A2CB5E for ; Sun, 17 Nov 2019 17:22:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p6.oit.umn.edu ([127.0.0.1]) by localhost (mta-p6.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v3Hyx6LoKSkj for ; Sun, 17 Nov 2019 11:22:56 -0600 (CST) Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p6.oit.umn.edu (Postfix) with ESMTPS id 1DF75B4B for ; Sun, 17 Nov 2019 11:22:56 -0600 (CST) Received: by mail-yb1-f198.google.com with SMTP id j66so11788888ybg.8 for ; Sun, 17 Nov 2019 09:22:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=RIby2qRx5cEwNIrcIoDIHdDJ6ejQhdeyp3owCLM8obk=; b=IRanUKstwT1MnUfDW4znsizornJMbx0pRICZZKzplIGIiA3OJ+MupXA0DK7QXt6M9c hLWZAgq6YTjDz4dClo6XI8qh6O0AEshigJzSARu8dQPCU/R2YI+MPH1d8HMEVvptX2LP 2CqovGn7TmSCS387hLEScYeCaCvqJ7vdrnljOcqfc19SjC6HnDNMpXbGuCNHzOtb4iDh bzFKDt1m+gnvDulkJgW4pgrRQ6i895IiisubEZ7hz9iMljjm1AQWK17ZTWMch9u/EvYT NccpkOgcjITRXlYagZbOT2+7he8di4ZPpkTv9UfOdlWEinhxUTaz056LWuOkx75Bq4gO mg0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RIby2qRx5cEwNIrcIoDIHdDJ6ejQhdeyp3owCLM8obk=; b=JIc0lQxphpMlKBDqEpGFxIMDXKyCC9Rv/NkH/5qrvvjvA05favqRz8etMWiLcRhVIa 1uWbAP6CBC7m9Sb3ztKAVwqtdSsfAJ5RpAqfD30ayIsNx8VG7vzBWtO/ypiHaiYiEuxs rVTZP/J+k8bjdg3kj0kbSlWuzpgY8jG9xyPfL73m23KdqXJSzQ0zkS30z1/+E3s8EwW+ kubahSY9VaZQvvFv7vit3l79YC1s656ucEaJhIz/EWhg6JIStzWM/B6EAG+jUqVPnvf3 71SGPqqMlEb/wFtR7yo1g1LwCoP3vd1gpa6oDOkxMfBcX2mlcgC2+d94T+0u7Leno3LZ UoPw== X-Gm-Message-State: APjAAAVD7lYWJ62tTRl/Gb/Wy6yq9CCHLJCj9Hd+ra+5eYkczvA6oZms CpsiOxnhmUUujXA3m52R2JCaXc3OVZ7i6X08sJI7g6CnfnCeSuSSvPaNu+SWSwzB3Vj7i66o4Yz r3Yk9zef7VY4aH8kiu18jzSscML93 X-Received: by 2002:a81:71c4:: with SMTP id m187mr16741526ywc.327.1574011375498; Sun, 17 Nov 2019 09:22:55 -0800 (PST) X-Received: by 2002:a81:71c4:: with SMTP id m187mr16741510ywc.327.1574011375242; Sun, 17 Nov 2019 09:22:55 -0800 (PST) Received: from cs-u-syssec1.dtc.umn.edu (cs-u-syssec1.cs.umn.edu. [128.101.106.66]) by smtp.gmail.com with ESMTPSA id 124sm6654970ywo.98.2019.11.17.09.22.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Nov 2019 09:22:54 -0800 (PST) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, Harry Wentland , Leo Li , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter , Bhawanpreet Lakha , Anthony Koo , Jun Lei , David Francis , Eric Yang , Nikola Cornij , Eric Bernstein , Chris Park , Wenjing Liu , David Galiffi , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amd/display: Fix error returned by program_hpd_filter Date: Sun, 17 Nov 2019 11:22:34 -0600 Message-Id: <20191117172236.2140-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org program_hpd_filter() currently fails to check for the errors returned in construct(). This patch returns error in case of failure. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c index ca20b150afcc..bbb648a50c41 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c @@ -1379,9 +1379,8 @@ static bool construct( * If GPIO isn't programmed correctly HPD might not rise or drain * fast enough, leading to bounces. */ - program_hpd_filter(link); + return program_hpd_filter(link); - return true; device_tag_fail: link->link_enc->funcs->destroy(&link->link_enc); link_enc_create_fail: -- 2.17.1