Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: YTejGEgNHh/Z+WZ9z5afUg+Swmek9Rpvcw+5hOAhPQgeT45l5uD7ljnwTKLefqWpQOpTYzsBLn
 4LcbEErtnwlVtA8uddiSTo4wsogOHhAQGKseOfwwMMxI01ta8fpTXNTlB41QgAfKlglASxQOBZ
 NUN/Nzoe5eWFUqpwK+eirohw9F5OHvlpix84GkpELb5VIc6k7iwy1KWpRo7uZ99BNRVh8UiEUO
 yReDbRaIUid7I6cnB3wf4QQ59oYQbuqgmWfe4w4UgUWC9+nav0efJ0K7ApkURenK9C7yZq+yC+
 mh0=
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     YueHaibing <yuehaibing@huawei.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        Jens Axboe <axboe@kernel.dk>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] scsi: sd_zbc: Remove set but not used variable
 'buflen'
Thread-Topic: [PATCH -next] scsi: sd_zbc: Remove set but not used variable
 'buflen'
Thread-Index: AQHVm7dj0yj5L8RVIk6wU+rJbBb19w==
Date:   Sun, 17 Nov 2019 23:56:40 +0000
Message-ID: <BYAPR04MB58168330EBC014EAD1BBC980E7720@BYAPR04MB5816.namprd04.prod.outlook.com>
References: <20191115131829.162946-1-yuehaibing@huawei.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a7d4d97-edc3-471f-a5f4-08d76bb9ca54
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2019 23:56:40.2872
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: b9Gc+qRKXmg3pAm+Vb7vO89J72Y+kUvBHdWHLtQxdbe0U4wDi0T373DxavoGqLbgIv7KENey8aXJK+0lFYLhzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4920
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2019/11/15 22:20, YueHaibing wrote:=0A=
> Fixes gcc '-Wunused-but-set-variable' warning:=0A=
> =0A=
> drivers/scsi/sd_zbc.c: In function 'sd_zbc_check_zones':=0A=
> drivers/scsi/sd_zbc.c:341:9: warning:=0A=
>  variable 'buflen' set but not used [-Wunused-but-set-variable]=0A=
> =0A=
> It is not used since commit d9dd73087a8b ("block: Enhance=0A=
> blk_revalidate_disk_zones()")=0A=
> =0A=
> Reported-by: Hulk Robot <hulkci@huawei.com>=0A=
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>=0A=
> ---=0A=
>  drivers/scsi/sd_zbc.c | 2 --=0A=
>  1 file changed, 2 deletions(-)=0A=
> =0A=
> diff --git a/drivers/scsi/sd_zbc.c b/drivers/scsi/sd_zbc.c=0A=
> index 23281825ec38..0e5ede48f045 100644=0A=
> --- a/drivers/scsi/sd_zbc.c=0A=
> +++ b/drivers/scsi/sd_zbc.c=0A=
> @@ -338,7 +338,6 @@ static int sd_zbc_check_zoned_characteristics(struct =
scsi_disk *sdkp,=0A=
>  static int sd_zbc_check_zones(struct scsi_disk *sdkp, unsigned char *buf=
,=0A=
>  			      u32 *zblocks)=0A=
>  {=0A=
> -	size_t buflen;=0A=
>  	u64 zone_blocks =3D 0;=0A=
>  	sector_t max_lba;=0A=
>  	unsigned char *rec;=0A=
> @@ -363,7 +362,6 @@ static int sd_zbc_check_zones(struct scsi_disk *sdkp,=
 unsigned char *buf,=0A=
>  	}=0A=
>  =0A=
>  	/* Parse REPORT ZONES header */=0A=
> -	buflen =3D min_t(size_t, get_unaligned_be32(&buf[0]) + 64, SD_BUF_SIZE)=
;=0A=
>  	rec =3D buf + 64;=0A=
>  	zone_blocks =3D get_unaligned_be64(&rec[8]);=0A=
>  	if (!zone_blocks || !is_power_of_2(zone_blocks)) {=0A=
=0A=
Good catch !=0A=
=0A=
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=