Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: QVAehKPDbbPrMVSnHqbo7FAF31zVOt8tU74SrcByLWob+oWYilZ7hq32DDiY+jOvHV+o3hBSDR
 iD8lgcx8tcyx00U5Eb4MSfWt4Xl63D0v22yA8R2rsFys3TXHRMOgYBFFjGREMo1wBR5B+D5nEg
 bcfDBtQXeEbcZV78oWGQTpo5C+3a9VwqPfv3S2iafBgeXbovO0ryqWztge7MfSo7sy0HjlSbLK
 JA2UwzvANMGji/XKj9iYmHd+ZPTC6igCOc/NshluayFytgh8W6kQ3X3BigR96C9unIAdZHryyu
 F6I=
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     Frederick Lawler <fred@fredlawl.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>
CC:     "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>
Subject: Re: [PATCH v2 2/4] skd: Replace magic numbers with PCI constants
Thread-Topic: [PATCH v2 2/4] skd: Replace magic numbers with PCI constants
Thread-Index: AQHVnaYi33hLetsYh0O/iIIdyDhL/Q==
Date:   Mon, 18 Nov 2019 01:45:51 +0000
Message-ID: <BYAPR04MB58162980CA2A2244626C999DE74D0@BYAPR04MB5816.namprd04.prod.outlook.com>
References: <20191118002057.9596-1-fred@fredlawl.com>
 <20191118002057.9596-3-fred@fredlawl.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b5231936-d835-4b5a-336c-08d76bc90b02
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2019 01:45:51.1677
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QN6X5PKPFCC+FxOJ1Vg05kVwzZjEaF5RDAQLYGuDkZoCkZmUMBNGQgMZzn/HeJ4fLTb+CQfJFhCsZ4nwcXtH2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB5864
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2019/11/18 9:21, Frederick Lawler wrote:=0A=
> Readability was improved by replacing pci_read_config_word() with=0A=
> pcie_capability_read_word(). Take that a step further by replacing magic=
=0A=
> numbers with PCI reg constants.=0A=
> =0A=
> No functional change intended.=0A=
> =0A=
> Signed-off-by: Frederick Lawler <fred@fredlawl.com>=0A=
> ---=0A=
> v2=0A=
> - Added this patch=0A=
> ---=0A=
>  drivers/block/skd_main.c | 8 +++++---=0A=
>  1 file changed, 5 insertions(+), 3 deletions(-)=0A=
> =0A=
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c=0A=
> index f25f6ef6b4c7..7f8243573ad9 100644=0A=
> --- a/drivers/block/skd_main.c=0A=
> +++ b/drivers/block/skd_main.c=0A=
> @@ -3141,9 +3141,11 @@ static char *skd_pci_info(struct skd_device *skdev=
, char *str)=0A=
>  		char lwstr[6];=0A=
>  		uint16_t pcie_lstat, lspeed, lwidth;=0A=
>  =0A=
> -		pcie_capability_read_word(skdev->pdev, 0x12, &pcie_lstat);=0A=
> -		lspeed =3D pcie_lstat & (0xF);=0A=
> -		lwidth =3D (pcie_lstat & 0x3F0) >> 4;=0A=
> +		pcie_capability_read_word(skdev->pdev, PCI_EXP_LNKSTA,=0A=
> +					  &pcie_lstat);=0A=
> +		lspeed =3D pcie_lstat & PCI_EXP_LNKSTA_CLS;=0A=
> +		lwidth =3D (pcie_lstat & PCI_EXP_LNKSTA_NLW) >>=0A=
> +			 PCI_EXP_LNKSTA_NLW_SHIFT;=0A=
>  =0A=
>  		if (lspeed =3D=3D 1)=0A=
>  			strcat(str, "2.5GT/s ");=0A=
> =0A=
=0A=
Looks OK to me. But since this is changing again one line that is added=0A=
by patch 1/4, why not make patch 1 and this patch changes a single patch ?=
=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=