Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] vrf: Fix possible NULL pointer oops when delete nic
To:     "wangxiaogang (F)" <wangxiaogang3@huawei.com>, dsahern@kernel.org,
        shrijeet@gmail.com, davem@davemloft.net
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        hujunwei4@huawei.com, xuhanbing@huawei.com,
        Taehee Yoo <ap420073@gmail.com>
References: <60e827cb-2bba-2b7e-55dc-651103e9905f@huawei.com>
 <fde95f03-72ee-b4e9-7f14-b98e3227f0f4@gmail.com>
 <517baa2a-2c42-7790-e225-02d22c5ed90b@huawei.com>
From:   David Ahern <dsahern@gmail.com>
Message-ID: <e908c58d-4bab-4b96-be3f-7e5d589b2050@gmail.com>
Date:   Sun, 17 Nov 2019 20:22:47 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <517baa2a-2c42-7790-e225-02d22c5ed90b@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/17/19 8:15 PM, wangxiaogang (F) wrote:
> 
> 
> On 2019/11/15 21:14, David Ahern wrote:
>> On 11/14/19 11:22 PM, wangxiaogang (F) wrote:
>>> From: XiaoGang Wang <wangxiaogang3@huawei.com>
>>>
>>> Recently we get a crash when access illegal address (0xc0),
>>> which will occasionally appear when deleting a physical NIC with vrf.
>>>
>>
>> How long have you been running this test?
>>
>> I am wondering if this is fallout from the recent adjacency changes in
>> commits 5343da4c1742 through f3b0a18bb6cb.
>>
>>
>>
>>
>>
> Thank you so much for the reply, our kernel version is linux 4.19.
> this problem happened once in our production environment.
> 

ok, so the recent adjacency changes would not be at fault here.