Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: ZK5ier2GwSRo28y5atVp7EKXxphO2ifpKHbbkG68nFkM2UfHc+JR3ISNLpSYFe1r1XeJsxF0VL
 HUi54Ph9/YyWp3SrvMptswuMY72aSVOKePP04JsH6kNqEpYCT5vnii+JxCdtlOxCgdIN0E+qgM
 Fvmz3q286dETnAlhI22JLacG1K6qiPWQxONrhNU1Yqos0FH6fk0L5BPWF98LYM235otqVkfNrx
 /AHALPVjlK1XF9pRPvOpFn9luPQpXOEfvtLSFJ7BGsbAOleUzCLg0IsDqr/Y7irzK0f07MNZ5E
 s5E=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <cang@qti.qualcomm.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
        "rnayak@codeaurora.org" <rnayak@codeaurora.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>,
        "saravanak@google.com" <saravanak@google.com>,
        "salyzyn@google.com" <salyzyn@google.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>
CC:     Alim Akhtar <alim.akhtar@samsung.com>,
        Pedro Sousa <pedrom.sousa@synopsys.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Bean Huo <beanhuo@micron.com>,
        Tomas Winkler <tomas.winkler@intel.com>,
        Venkat Gopalakrishnan <venkatg@codeaurora.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 4/4] scsi: ufs: Complete pending requests in host reset
 and restore path
Thread-Topic: [PATCH v2 4/4] scsi: ufs: Complete pending requests in host
 reset and restore path
Thread-Index: AQHVncN4zcr808K5tU2/O7vxUpZlnaeQhWUQ
Date:   Mon, 18 Nov 2019 07:21:00 +0000
Message-ID: <MN2PR04MB6991736BCE24A155BFD9A862FC4D0@MN2PR04MB6991.namprd04.prod.outlook.com>
References: <1574049061-11417-1-git-send-email-cang@qti.qualcomm.com>
 <1574049061-11417-5-git-send-email-cang@qti.qualcomm.com>
In-Reply-To: <1574049061-11417-5-git-send-email-cang@qti.qualcomm.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ceecd1f-5b67-48c5-f1cb-08d76bf7dccb
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2019 07:21:00.0407
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DoFfNZIk3e85lptXmEWLAR0JfwTnLo/cagCrtIuVjYQVJP7+lOrNYMT106L4tOPOeDk7AoHrU3VKb1Lo6j74fA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6976
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>=20
>=20
> From: Can Guo <cang@codeaurora.org>
>=20
> In UFS host reset and restore path, before probe, we stop and start the h=
ost
> controller once. After host controller is stopped, the pending requests, =
if any,
> are cleared from the doorbell, but no completion IRQ would be raised due =
to the
> hba is stopped.
> These pending requests shall be completed along with the first NOP_OUT
> command(as it is the first command which can raise a transfer completion
> IRQ) sent during probe.
> Since the OCSs of these pending requests are not SUCCESS(because they are=
 not
> yet literally finished), their UPIUs shall be dumped. When there are mult=
iple
> pending requests, the UPIU dump can be overwhelming and may lead to
> stability issues because it is in atomic context.
> Therefore, before probe, complete these pending requests right after host
> controller is stopped and silence the UPIU dump from them.
>=20
> Signed-off-by: Can Guo <cang@codeaurora.org>
Already reviewed by Alim & Bean, and tested by Bean.

Please keep those tag updated - will make it clear what is still required t=
o merge this series.

Thanks,
Avri