Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2648606ybc; Mon, 18 Nov 2019 02:28:12 -0800 (PST) X-Google-Smtp-Source: APXvYqzMiH6FCoGKtglNRMvqW2eFSZzyFDuoAeIAAPpcTXRPHKo9EUuasE7Y+B/yrwus1TNrxsYE X-Received: by 2002:a17:906:1354:: with SMTP id x20mr26211593ejb.131.1574072892593; Mon, 18 Nov 2019 02:28:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574072892; cv=none; d=google.com; s=arc-20160816; b=Be6w1VwAD1JO7w/lXFiHPtGceIXJAosRpSd6/dJ98Q7d2HS5ERMlLav8ck1neoujf/ hLj+SzEKIeLftpuwKH6/WwO1AFCKvVrSRvwSt/XR6RLlivyx7nKJrO/Ve97IR2sw8Baf oTmMhr637N2MaJwtBInEDmj5sEN9QhN2TON+hv0N0Mwequt4208qEO48qivTS9DnJGpK 2HOn2tq/+6goqUe0moSya77YHWh0duKgWgNxjBYiGTCOj3VX4k6kCpObneLm5dhwoWAT +DuuA6OjiBShrpZCN5SFsNTeiqLiNR77XGvzsnpfMaF79pi2RlBku0sVrRMI7dM4ZZ+E TzFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :references:subject:cc:to:mime-version:user-agent:from:date :message-id; bh=tMltvVyTY60cx+nVE12RlV+Ji+z8KbK+vw4/idBZvpA=; b=poA5dTuZ8OXGoIDNP8ouUHfYWXY8mEPtTVnWWqrBk+j2gd985oXMIF5A73+xsTlFO7 6o/fa/Vaf3ucGUxZ09VpYoB0j7g4X4gaW3jZEHh+t0HTJZ6SQkW2kGMiv7onTWKYVwoH cHSMs6N6aOKt4wWwcAkNvy2ZhbMDN2Rk58D44l7dAxr8rvI038VxcLz5FEwaCWxWO4AG +zNA5rizEKISX3wLTDizu9sIr7yP1qbblVCrIzXmGrYHgIMgyZmi39bqAkHa1XT7Gr+y ODJkeVyza7uKfemVA7yq6qre/DG68W5J2RDzAq2gB97nwG5HOAeBRi3RA9qYlG0SnI22 8Lzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o22si4508440ejr.78.2019.11.18.02.27.48; Mon, 18 Nov 2019 02:28:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726761AbfKRKYe (ORCPT + 99 others); Mon, 18 Nov 2019 05:24:34 -0500 Received: from mga17.intel.com ([192.55.52.151]:18925 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726460AbfKRKYe (ORCPT ); Mon, 18 Nov 2019 05:24:34 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 02:24:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,319,1569308400"; d="scan'208";a="208807990" Received: from unknown (HELO [10.239.13.7]) ([10.239.13.7]) by orsmga003.jf.intel.com with ESMTP; 18 Nov 2019 02:24:31 -0800 Message-ID: <5DD272F7.4070008@intel.com> Date: Mon, 18 Nov 2019 18:31:19 +0800 From: Wei Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Michael S. Tsirkin" CC: Khazhismel Kumykov , jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] virtio_balloon: fix shrinker pages_to_free calculation References: <20191115225557.61847-1-khazhy@google.com> <5DD21784.8020506@intel.com> <20191118002652-mutt-send-email-mst@kernel.org> <5DD24B52.4090603@intel.com> <20191118032416-mutt-send-email-mst@kernel.org> In-Reply-To: <20191118032416-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/2019 04:26 PM, Michael S. Tsirkin wrote: > > The order is called VIRTIO_BALLOON_FREE_PAGE_ORDER > making it sounds like there's a free page > and that's it order. > > Let's rename that hont block? > So VIRTIO_BALLOON_HINT_BLOCK_ORDER ? > > VIRTIO_BALLOON_PAGES_PER_HINT_BLOCK ? Sounds good. Best, Wei