Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 18 Nov 2019 11:46:51 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Alexey Budankov <alexey.budankov@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] perf session: fix decompression of
 PERF_RECORD_COMPRESSED records
Message-ID: <20191118104651.GE28372@krava>
References: <237222f1-9765-dce1-601c-60530a7fc844@linux.intel.com>
 <20191115151124.GA25246@krava>
 <2f2b2421-6865-4669-7e30-918d12ae5e01@linux.intel.com>
MIME-Version: 1.0
In-Reply-To: <2f2b2421-6865-4669-7e30-918d12ae5e01@linux.intel.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 15, 2019 at 08:09:19PM +0300, Alexey Budankov wrote:
>=20
> On 15.11.2019 18:11, Jiri Olsa wrote:
> > On Fri, Nov 15, 2019 at 12:05:14PM +0300, Alexey Budankov wrote:
> <SNIP>
> >> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> >> index f07b8ecb91bc..3f6f812ec4ed 100644
> >> --- a/tools/perf/util/session.c
> >> +++ b/tools/perf/util/session.c
> >> @@ -1957,9 +1957,31 @@ static int __perf_session__process_pipe_events(=
struct perf_session *session)
> >>  =09return err;
> >>  }
> >> =20
> >> +static union perf_event *
> >> +prefetch_event(char *buf, u64 head, size_t mmap_size,
> >> +=09       bool needs_swap, union perf_event *ret);
> >=20
> > why not move prefetch_event definition in here?
> > I don't see any need for the static declaration..
>=20
> It is just for the sake of more readable patch formatting=20
> and, yes, could be avoided and replaced by the definition.

I think we're trying to avoid static declarations

>=20
> >=20
> >> +
> >>  static union perf_event *
> >>  fetch_mmaped_event(struct perf_session *session,
> >>  =09=09   u64 head, size_t mmap_size, char *buf)
> >> +{
> >> +=09return prefetch_event(buf, head, mmap_size,
> >> +=09=09=09      session->header.needs_swap,
> >> +=09=09=09      ERR_PTR(-EINVAL));
> >> +}
> >> +
> >> +static union perf_event *
> >> +fetch_decomp_event(struct perf_session *session,
> >> +=09=09   u64 head, size_t mmap_size, char *buf)
> >> +{
> >=20
> > if this is decomp specific, it could take 'struct decomp*' as argument
>=20
> Well, it makes sense. whole session object is not required here.
> Just session->header.needs_swap could be passed as a param.
> Shall we make it like this?
>=20
> static union perf_event *=20
> fetch_decomp_event(u64 head, size_t mmap_size, char *buf, bool needs_swap=
)

ok, I just saw the call passing all the stuff from 'struct decomp'
so I thought it'd save some arguments if we pass the  struct itself
instead

jirka