Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2723294ybc; Mon, 18 Nov 2019 03:42:58 -0800 (PST) X-Google-Smtp-Source: APXvYqzSj3TC8BXFk32NDEQGrevmjf967wO1rJzUPYA2+5sJykikjveBCWMwHP4E3yCHxaxoYFiL X-Received: by 2002:a17:906:6c95:: with SMTP id s21mr26733875ejr.205.1574077378395; Mon, 18 Nov 2019 03:42:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574077378; cv=none; d=google.com; s=arc-20160816; b=CoRS1jqtZA0/Waa5uV8wLDg+/k4cQNCSWSjJANLGlu+HSG0DTbFGEEKYsuQIw0IdSq AxkBjfkVlW/M1LL3oQcKMOLThn817aTEGg9O4IzYsl415Gy4nkHltzInfIdNwPkWnLCk YB79pZpWia6w6aGxOPVk0wNG/hLbP3uxirgflG/zan92dVlo0HOYkBays7Dlj2tHyHVi 7J6B3ykkz79kHF+j+smeJis46HuvjbdNb0maoNyqvJ5PKO/odSQlr+yJfbv4yhQk5Z+B f1/L+qyInKElAaDtHtRXuSKtScna3cZwzuefHWM7p0Wy7Egsfss+P6qZBSBLqTJVTdJF RKNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=uMmNWssOJlXbtofRR2kOKtfa7UxH0Ox6Pxi8KF9bxWY=; b=lnxQ2xVaspMNYhgWx5FOUt2+5TQ7y0OXwSwsX4o8Z9w/7zz2RpbxSm5+PcmeaOUm3z KI+NT/60PuOFw4Rw6tIuFI7NOvoQ/P6DLGsdBgQSINgoP5PNlVAF9FjeQoNqyQi+gBa2 A5Q3hPpg5zLxPWcE8D0gJuVX7x2Xn01UpaTH2czn4kK+hQCn2LBNncsk7XJfQb0FJH+S +k1dWZFLMcJii6dUC5lW8BOpEr1+lL1x8mzw5hg69FID8zuJyEFDAyU3JiyiwD4jlNXV XNLFshm5rU0YuNJC5ZhVgEIbOmGSPvuZFCVrc6ACg2TzPU+I1Vq5X9RH8qGY0Y5V4JKV N/3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="qAbxj/zI"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c2si14331741eda.322.2019.11.18.03.42.35; Mon, 18 Nov 2019 03:42:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="qAbxj/zI"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbfKRLlG (ORCPT + 99 others); Mon, 18 Nov 2019 06:41:06 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:45081 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726539AbfKRLlF (ORCPT ); Mon, 18 Nov 2019 06:41:05 -0500 Received: by mail-pl1-f195.google.com with SMTP id w7so9647288plz.12 for ; Mon, 18 Nov 2019 03:41:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uMmNWssOJlXbtofRR2kOKtfa7UxH0Ox6Pxi8KF9bxWY=; b=qAbxj/zIvkWlxT5u0mKDsMBil9jocSm3LCCd8FO0IcGNqyTmQ1XWHFGVAaLkzH3/cO j+FzzcK8AbDUDyIdFjZouNA8sWKs3Sy5LqPjEdWPU+UtmT/ZSztXmVbwIZiRfUYH1WU3 4snZJ4bTdVT4Ac/TsILCF90eQXpAqYVOFgh4nxvTTPlqRgSnPVA/0qksjrq4dgFXg3aM 51uGbkS4k+WiHODUJhHsN8sQYw02vqQff13CcWfadwaFpmVTEL3jhaEg9T+nRXWpfWpZ NiX4bT8JOdQYb7x9w9R73Ga/QgQftA6h2/prthwToVdET5WhBBam1nbJeRpiMu6T+EAC g1hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uMmNWssOJlXbtofRR2kOKtfa7UxH0Ox6Pxi8KF9bxWY=; b=Dnl7oftMnIKOXtUZD0xcr+XWZmbJBsqzEHgMDNBIMHaiLR4HV7GrW7KksvRPrFDr7N E9KpM6hfY7w3hHo9IPVLEdj+utt2c/YQI7dvJjZkyfftpEjLeGbhK49BAX6Lq6JNO325 1vtTewIo3fMLHrZKSlabBbltaFs6bkxQKTtEGKsQlSoSzUAk0WB7NQprHvzLN9W2C5wW CPm/vMm/jspGLaTF60O17AkHHttulxMVj/tNRyoI7qtlhZm8lDh6FK8PfadONGbC442d PfhwktCO9D7eo7m5pkoBsFgrt89zaxHSJ2Y9rI8xhH8JXwWbPbEmLUrNGBz+rftfdmg+ Bo/g== X-Gm-Message-State: APjAAAXQKHAknm0HkKsQA9xFCTL1SpCEDPjUQXZHwt+TSlYSb/HhVl+x AtihCMvRxT9XVHp8+GAylcY= X-Received: by 2002:a17:90a:f013:: with SMTP id bt19mr38840524pjb.16.1574077265326; Mon, 18 Nov 2019 03:41:05 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id a21sm19124492pjv.20.2019.11.18.03.41.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 03:41:04 -0800 (PST) From: Chuhong Yuan Cc: Lee Jones , linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] mfd: tps65010: add missed gpiochip_remove Date: Mon, 18 Nov 2019 19:40:56 +0800 Message-Id: <20191118114056.25552-1-hslester96@gmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver forgets to call gpiochip_remove to match gpiochip_add_data in probe. Add the missed call to fix it. Signed-off-by: Chuhong Yuan --- drivers/mfd/tps65010.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/tps65010.c b/drivers/mfd/tps65010.c index 65fcc58c02da..f73abba7be51 100644 --- a/drivers/mfd/tps65010.c +++ b/drivers/mfd/tps65010.c @@ -513,6 +513,7 @@ static int tps65010_remove(struct i2c_client *client) dev_dbg(&client->dev, "board %s %s err %d\n", "teardown", client->name, status); } + gpiochip_remove(&tps->chip); if (client->irq > 0) free_irq(client->irq, tps); cancel_delayed_work_sync(&tps->work); -- 2.24.0