Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2724836ybc; Mon, 18 Nov 2019 03:44:34 -0800 (PST) X-Google-Smtp-Source: APXvYqysYTiOBDWOfJHxb9N6o8lrZTg5yFIpMQiBDY9wVuQun5zVg6UoPzy6XzkyneFlJUB1f1Rm X-Received: by 2002:a17:906:e0d5:: with SMTP id gl21mr25399262ejb.292.1574077473904; Mon, 18 Nov 2019 03:44:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574077473; cv=none; d=google.com; s=arc-20160816; b=t2T90zr8oyZGArMv9WhzWVMC9Ra3/Bg9tpAgCAQIHlszo78xu+UsVlld/L2rTAM5Nt pD4G7B7sWwfrjEie895Mm770FmTJfOjBhPKpUF/DR7G4fzkxNkmHPipXXzyqdZroSoI4 JHqlnWP+RfA/tHKoJZ5KaWJXwJ5dBPSUSMc1l1xbCQgdK00U1hW2bH4afCOkhxZCD2zB BogK7G3VZ1LeK55HdgqWEEvzTYqP8PM6+LkoDhoEDYPsL35NSoQbIgNFM8HzatnW7gDT nY381raWVH2xeGo63b71D1FqNbW2vMh2lKWOyeXYw6iTqcPuQ4jGafbWoAZYYQpNfPsS szpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=GUSVLZmMqCMWMeD0FT4xlPzHbtQaXySLAxO0s7N20fw=; b=03eGq9AUNp7io7wtVgyTkxE/BTB0b3gF3aXuUu+apDCJEoA6qNjmTSLCMAtMoTkY5f ep/WubSj4eLyY0S8Z7cA7PRnsHA27LYhC1H6o0yP8Dq4FncDGluoAb/UdBqMU9FUjMw6 gAMlWz/xK2CKM59l9AMnGagwDzLEGVp/Tzm8zeA7u57MjNBcDQUSECnwRCVtAOI54GHF KfIl4rC/d112G7I1laQ0XHiexuv7FaOnJKpqD+W2GLUR/PL7tv6VTs9Ijs+F7ZwuZiWu 2VP3wSo0Z0xfUB5p/+1uUIBrnS1KN+HV9TeB5bj/ZvndioBfgyoJPGX+sy09DuG8Dz8R ukVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=OyaN94NX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i10si11500760ejj.8.2019.11.18.03.44.10; Mon, 18 Nov 2019 03:44:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=OyaN94NX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727104AbfKRLmA (ORCPT + 99 others); Mon, 18 Nov 2019 06:42:00 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:39740 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726460AbfKRLl7 (ORCPT ); Mon, 18 Nov 2019 06:41:59 -0500 Received: by mail-pg1-f193.google.com with SMTP id 29so9522662pgm.6; Mon, 18 Nov 2019 03:41:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GUSVLZmMqCMWMeD0FT4xlPzHbtQaXySLAxO0s7N20fw=; b=OyaN94NXMpCVElZ8Jw1WSv1yyO+jM2NeUo+yFOKhRx4WUNFccidxt6IWuwEiFy84z+ tNQg5QGqeNbQPOTBhrRHcHxbWgMkT157Ebb4Dz1jWP/askkCcH8pofzUjkl8IDLGkhC0 Wr9nznlGpUgn+s3PUWzUS0mwNmyJPLvXaYhWsRrOuZixx63Bn7APNEKGoqcr7pV9LImk QU++7ig0TwtFloemfAXCPH9Pu8q1dVP8nAillJt4c6ATNHv54emIlGz6FX0EuTXP2xWJ ZXUK9J8VmhbowEhKNbgtceawRPuCkvQXlDFiRTo6I7mm+WemE1CBJ8P4uboM+bPfoO1f Ln8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GUSVLZmMqCMWMeD0FT4xlPzHbtQaXySLAxO0s7N20fw=; b=M76rl0tuEw8cH0ub+2KLN2oIq1h7sL0CIhgm6pF8R+wwQ7jVO58krhDUmtAOgr3PC/ FEOsi0rcLUvsVhy5LviiIGzjotrBRg7nLRYhGrgElgZgVk4cHGe0dEVKdxClk8HqJDgK bPomTiteX93QQOEMp08arU7K6WkB95Qvpd0q0dQ4zXL/Xx8bUsZeKiYR6vtGVZM3Rvvq eQgOKMmEvV4beyC01q1qkQVgGqXWKVFX8v8XehOg7jAXzHtQ2mBhKnBeCRVbWK19SFva EGU4TYQPdLtFFHkW7/sVlsmaa7g7BsCV2wJ2f893/pM94yW4Xf6IkiM7RRyx3Ws8YLtr X1vw== X-Gm-Message-State: APjAAAVpwHQXVV9zGdMvhm82i2YHUaxUBWYIMyKsdJGiAdLaQPwsd2TI tF9PDrVBTh+29cqGPD2S56LORvP37NM= X-Received: by 2002:aa7:80d2:: with SMTP id a18mr15473101pfn.29.1574077319270; Mon, 18 Nov 2019 03:41:59 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id m19sm19455324pgh.31.2019.11.18.03.41.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 03:41:58 -0800 (PST) From: Chuhong Yuan Cc: Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] video: ssd1307fb: add the missed regulator_disable Date: Mon, 18 Nov 2019 19:41:50 +0800 Message-Id: <20191118114150.25724-1-hslester96@gmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver forgets to disable the regulator in remove like what is done in probe failure. Add the missed call to fix it. Signed-off-by: Chuhong Yuan --- drivers/video/fbdev/ssd1307fb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index 78ca7ffc40c2..819fbee18dda 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -791,6 +791,8 @@ static int ssd1307fb_remove(struct i2c_client *client) pwm_disable(par->pwm); pwm_put(par->pwm); } + if (par->vbat_reg) + regulator_disable(par->vbat_reg); fb_deferred_io_cleanup(info); __free_pages(__va(info->fix.smem_start), get_order(info->fix.smem_len)); framebuffer_release(info); -- 2.24.0