Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2962915ybc; Mon, 18 Nov 2019 07:26:35 -0800 (PST) X-Google-Smtp-Source: APXvYqyAaoRjuYGglRxA9VUFct0u3RUhqTIpfTATXHbwQkF7zyzDfFCNqkLHr4QkwSpT7S7l/3XJ X-Received: by 2002:a17:906:25c5:: with SMTP id n5mr26800091ejb.126.1574090795375; Mon, 18 Nov 2019 07:26:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574090795; cv=none; d=google.com; s=arc-20160816; b=qYGGN5hrGg/uEgJ78qAa65ehVF6r56Q+eik/CMQAeseaw5B7pyYhhHGDoJYvbw8mmR ClteBsC2dKLrFX3LUYafbqLvmAn3gPvsiIzJylTerEHjyp/yVGGzRB/Xw3pokGFqXlcK rbG/7gwIeSFpeVYAur9YDR+6uAOHoZ2uRA+UeuP7qFQoRSgu+czAH26XJIUwiN0J+qeE yKew81hgu/qZsropkdg038Qqmw3Q+XqWNEGsyi81YW+4kN8ATh7T3sz09VXmJrLf8SWb EfuNkAG8/ekvBory9cdkMCbfJu1IEZALpA2z/o7w2SG5wDQGj4wXjHCH7VEuiCob2r62 +A2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=3DBGZT5o0IoqoybmtmvMF65jxu5N/U+Mt6J18iL8TX8=; b=t0er05OUxmL99ZWXudRcN3iw99qaTuKgKdrS+SIQRxiJKErdHzI3bH5f9gwECRvuQP stQt0+Rxskw8vNYe9poJrUj+QKFEwrvuOd2KRsxRM4jWmFE1HKGv2XBko6wy63g07xO6 JExkriic4ug7SDoQ4xc4B3HhLzqa2MdAh2RBj5098GaaWWfFeMnHU5R05Gj3n9TELqsS NOI9Rli6yypRixzNJVyB2RCbPqlDXULoQ57zg6ZQ/rbI1nDuf1/3YgpSrkU8iiy0ZeVL EGPq2ADDIRCj1xBLRrKrram8dZTBfkNLMhXKfNegb32emqaICjyBEYvfQJ/bAeg0OQkn rB/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fy15si11767179ejb.432.2019.11.18.07.26.10; Mon, 18 Nov 2019 07:26:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727260AbfKRPZI (ORCPT + 99 others); Mon, 18 Nov 2019 10:25:08 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:56728 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726578AbfKRPZI (ORCPT ); Mon, 18 Nov 2019 10:25:08 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: aratiu) with ESMTPSA id 7B69B28DFE1 From: Adrian Ratiu To: linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-imx@nxp.com Subject: [PATCH v3 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver Date: Mon, 18 Nov 2019 17:25:14 +0200 Message-Id: <20191118152518.3374263-1-adrian.ratiu@collabora.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Having a generic Synopsis DesignWare MIPI-DSI host controller bridge driver is a very good idea, however the current implementation has hardcoded quite a lot of the register layouts used by the two supported SoC vendors, STM and Rockchip, which use IP cores v1.30 and v1.31. This makes it hard to support other SoC vendors like the FSL/NXP i.MX 6 which use older v1.01 cores or future versions because, based on history, layout changes should also be expected in new DSI versions / SoCs. This patch series converts the bridge and platform drivers to access registers via generic regmap APIs and allows each platform driver to configure its register layout via struct reg_fields, then adds support for the host controller found on i.MX 6. I only have i.MX hardware with MIPI-DSI panel and relevant documentation available for testing so I'll really appreciate it if someone could test the series on Rockchip and STM... eyeballing register fields could only get me so far, so sorry in advance for any breakage! Many thanks to Boris Brezillon for suggesting the regmap solution and to Liu Ying for doing the initial i.MX platform driver implementation. This series applies on top of latest linux-next tree, next-20191118. v2 -> v3: * Added const declarations to dw-mipi-dsi.c structs (Emil) * Fixed Reviewed-by tags and cc'd some more relevant ML (Emil) v1 -> v2: * Moved register definitions & regmap initialization into bridge module. Platform drivers get the regmap via plat_data after calling the bridge probe (Emil). Adrian Ratiu (4): drm: bridge: dw_mipi_dsi: access registers via a regmap drm: bridge: dw_mipi_dsi: abstract register access using reg_fields drm: imx: Add i.MX 6 MIPI DSI host driver dt-bindings: display: add IMX MIPI DSI host controller doc .../bindings/display/imx/mipi-dsi.txt | 56 ++ drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 699 +++++++++++++----- drivers/gpu/drm/imx/Kconfig | 7 + drivers/gpu/drm/imx/Makefile | 1 + drivers/gpu/drm/imx/dw_mipi_dsi-imx.c | 378 ++++++++++ .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 17 +- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 34 +- include/drm/bridge/dw_mipi_dsi.h | 2 +- 8 files changed, 987 insertions(+), 207 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/imx/mipi-dsi.txt create mode 100644 drivers/gpu/drm/imx/dw_mipi_dsi-imx.c -- 2.24.0