Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191115201225.92888-1-lrizzo@google.com> <20191116.131058.1856199123293908506.davem@davemloft.net>
 <59ebfae8-ac93-75a1-7a60-2bb3820a9a79@mellanox.com> <20191117.102949.1712366954266607838.davem@davemloft.net>
In-Reply-To: <20191117.102949.1712366954266607838.davem@davemloft.net>
From:   Luigi Rizzo <lrizzo@google.com>
Date:   Mon, 18 Nov 2019 09:38:52 -0800
Message-ID: <CAMOZA0LWNaK+bwDvUchRdB3enz=Dw4jUDCAY-6e0ty=iT6pytw@mail.gmail.com>
Subject: Re: [PATCH] net/mlx4_en: fix mlx4 ethtool -N insertion
To:     David Miller <davem@davemloft.net>
Cc:     tariqt@mellanox.com, netdev@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Nov 17, 2019 at 10:29 AM David Miller <davem@davemloft.net> wrote:
>
> From: Tariq Toukan <tariqt@mellanox.com>
> Date: Sun, 17 Nov 2019 14:46:50 +0000
>
> >
> >
> > On 11/16/2019 11:10 PM, David Miller wrote:
> >> From: Luigi Rizzo <lrizzo@google.com>
> >> Date: Fri, 15 Nov 2019 12:12:25 -0800
> >>
> >>> ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the
> >>> total number of entries in the rx classifier table.  Surprisingly, mlx4
> >>> is missing this part (in principle ethtool could still move forward and
> >>> try the insert).
> >>>
> >>> Tested: compiled and run command:
> >>>     phh13:~# ethtool -N eth1 flow-type udp4  queue 4
> >>>     Added rule with ID 255
> >>>
> >>> Signed-off-by: Luigi Rizzo <lrizzo@google.com>
> >>> Change-Id: I18a72f08dfcfb6b9f6aa80fbc12d58553e1fda76
> >>
> >> Luigi, _always_ CC: the appropriate maintainer when making changes to the
> >> kernel, as per the top-level MAINTAINERS file.
> >>
> >> Tariq et al., please review.
> >>
> >
> > Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
>
> Applied and queued up for -stable, with Change-Id: removed.


Thank you all, apologies for mistakes.

cheers
luigi