Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3254701ybc; Mon, 18 Nov 2019 12:06:02 -0800 (PST) X-Google-Smtp-Source: APXvYqxYbSyBPdd7JqPQ7AdURkVETXcrRDr3tSUwYNhqVcn84WMJrR+aS+VAAf3sGOXGLdgjFjk3 X-Received: by 2002:a17:906:d9c4:: with SMTP id qk4mr28124511ejb.214.1574107562375; Mon, 18 Nov 2019 12:06:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574107562; cv=none; d=google.com; s=arc-20160816; b=rG/vMRIHo4tsxXJMXl0TBP0B01kS9WZCEPnrHTGwdP+Bzz7BIt3w/BqctIWgq0FYdg zkmu14Ka0F7rV6pc8jYlhtDLxS9vWYvT3wguncd+LTpIzrehmr0QsroifHy/KMEFzYk3 ghh5CDkQJOSoho8WDokJiYcH9aM4af9/qB4cOfCpBis3TWbXpkikTjh8T8QcTmATm02T ZzWV2Kws64ZULFnPRfZCPnhPiil5cSKjgjHYxDLSSBfVnNdxpkPxS/rkOoYZDkbQpXqp 7IxeRSgTwG+MsmSMVwc6VapcTIBESXoDQG/nQIYtXXZwhdGJHjv7qQfmHtfYkZw8/ZYz bTvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=2PDaqtIBFBkrRQtsY42nVpJi6m3lJCgdaGJOcPD9Eus=; b=ye9xU5AS4FkO2+8O8B8577o6ZAGR4+UwxX9H7Xlbfgqv+KEE5ggnFZchy7sw334IR4 lagtLuTHq/qj5PqwZjDYlVsLnPHfVKJeGBJfTFXjaVF5fOL7mggQuBCfAOZ3aRg7NBAi 2kaVx3DgfSmpfiNxNBcDAH1iIqF4lRGu6ccbyfMIdVHff7rqNmIRwdrrRbeO7p0ikkTG e/QgsCWfiymp1LppZ9cMfU71wzSHvkLPohEOC9Yt0vjeMFl/tjb9sReOza7tNYUNfhcw Zuz/wrmW6tJGdLtBBrYpUfMlRW2De5QRxj6uWNhvhZZZjwo6iznTsnUYuc/o53LU6Cpd cCOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=UxPgDGEU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s17si9794417ejr.267.2019.11.18.12.05.36; Mon, 18 Nov 2019 12:06:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=UxPgDGEU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726647AbfKRUDe (ORCPT + 99 others); Mon, 18 Nov 2019 15:03:34 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:46369 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726250AbfKRUDe (ORCPT ); Mon, 18 Nov 2019 15:03:34 -0500 Received: by mail-ot1-f65.google.com with SMTP id n23so15629930otr.13 for ; Mon, 18 Nov 2019 12:03:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2PDaqtIBFBkrRQtsY42nVpJi6m3lJCgdaGJOcPD9Eus=; b=UxPgDGEUGSS2r8QojZ/ioqZmAmyhiiIEOQoy9RtBqwwu3kaOweSHsI8J4m2K+HhZA2 mjvPBHZeE6rg6BOyz/I2PnBSCrqeMEqNQ6qYLKjizgjbfQauOxWanDCnsw3hAhfcpw40 76vwRpGOIpHjgHlFudj72VJL3sr8VtLtvfikY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2PDaqtIBFBkrRQtsY42nVpJi6m3lJCgdaGJOcPD9Eus=; b=unilPI85LeywuNmryr1T3BhswiZWmFUXN8XXYfCWEt3oSI3APWg83eh2wiFWFCjqk6 p1AFGTFpXUb/FNYZ7HzrZgIsgSQZrL8U1H5W0QY9Utlm4YD2m4eO5Rn48ALFeD8aS2jZ 1kpG+/X//g58JGWq5U7GIPnYrZF4pr+CZN//eev5ndeBntPOmlwWkOO8BS2JgghtbqF4 nGRnf6HBO4xSDc1+YA3b+GN9FUDxoVONulAJeBfEw0W10FAIQOBb6v0RlMJb2JEuJDtL OUm+7F63aOWI2bJnMVndNWN251RijU7fAW4v8DiEzTiaxwkdwypZRTjva1v13xECc8TQ eleg== X-Gm-Message-State: APjAAAV8Rub+ajgKkxeK8eRbYlavxK5Okmw+iWq0wTajE1XcWyX25yfm MoahI4yqVQqOiCx7Hf7KUAk2Ro0I+Ale59+WCufrRQ== X-Received: by 2002:a05:6830:22d0:: with SMTP id q16mr849080otc.188.1574107411531; Mon, 18 Nov 2019 12:03:31 -0800 (PST) MIME-Version: 1.0 References: <20191114132436.7232-1-wambui.karugax@gmail.com> <8736ep1hm2.fsf@intel.com> <20191118192450.GA135013@art_vandelay> In-Reply-To: <20191118192450.GA135013@art_vandelay> From: Daniel Vetter Date: Mon, 18 Nov 2019 21:03:20 +0100 Message-ID: Subject: Re: [PATCH 0/2] add new DRM_DEV_WARN macro To: Sean Paul Cc: Jani Nikula , Wambui Karuga , Maarten Lankhorst , Maxime Ripard , Dave Airlie , Sandy Huang , Linux ARM , "open list:ARM/Rockchip SoC..." , dri-devel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 18, 2019 at 8:24 PM Sean Paul wrote: > On Fri, Nov 15, 2019 at 01:52:53PM +0200, Jani Nikula wrote: > > On Thu, 14 Nov 2019, Wambui Karuga wrote: > > > This adds a new DRM_DEV_WARN helper macro for warnings log output that include > > > device pointers. It also includes the use of the DRM_DEV_WARN macro in > > > drm/rockchip to replace dev_warn. > > > > I'm trying to solicit new struct drm_device based logging macros, and > > starting to convert to those. [1] > > > > This sounds good to me, I'd much prefer the non-caps versions of these > functions. So let's wait for those to bubble up and then convert rockchip to > drm_dev_* Care to ack Jani's patch directly, so this is all formal? Jani, can you pls also add a todo.rst patch on top to adjust the relevant item to the new color choice? Wambui, I guess slight change of plans, it happens ... Cheers, Daniel > > Sean > > > BR, > > Jani. > > > > > > [1] http://patchwork.freedesktop.org/patch/msgid/63d1e72b99e9c13ee5b1b362a653ff9c21e19124.1572258936.git.jani.nikula@intel.com > > > > > > > > > > > > > > Wambui Karuga (2): > > > drm/print: add DRM_DEV_WARN macro > > > drm/rockchip: use DRM_DEV_WARN macro in debug output > > > > > > drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++- > > > include/drm/drm_print.h | 9 +++++++++ > > > 2 files changed, 11 insertions(+), 1 deletion(-) > > > > -- > > Jani Nikula, Intel Open Source Graphics Center > > -- > Sean Paul, Software Engineer, Google / Chromium OS -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch