Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1574110334.5937.142.camel@lca.pw>
Subject: Re: [PATCH -next v2] mm/vmscan: fix some -Wenum-conversion warnings
From:   Qian Cai <cai@lca.pw>
To:     Johannes Weiner <hannes@cmpxchg.org>
Cc:     akpm@linux-foundation.org, surenb@google.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Date:   Mon, 18 Nov 2019 15:52:14 -0500
In-Reply-To: <20191118182853.GC372119@cmpxchg.org>
References: <1573848697-29262-1-git-send-email-cai@lca.pw>
         <20191118182547.GA372119@cmpxchg.org> <20191118182853.GC372119@cmpxchg.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2019-11-18 at 13:28 -0500, Johannes Weiner wrote:
> On Mon, Nov 18, 2019 at 01:25:49PM -0500, Johannes Weiner wrote:
> > On Fri, Nov 15, 2019 at 03:11:37PM -0500, Qian Cai wrote:
> > > The -next commit "mm: vmscan: enforce inactive:active ratio at the
> > > reclaim root" [1] introduced some Clang -Wenum-conversion warnings,
> > > 
> > > mm/vmscan.c:2216:39: warning: implicit conversion from enumeration type
> > > 'enum lru_list' to different enumeration type 'enum node_stat_item'
> > > [-Wenum-conversion]
> > >         inactive = lruvec_page_state(lruvec, inactive_lru);
> > >                    ~~~~~~~~~~~~~~~~~         ^~~~~~~~~~~~
> > > mm/vmscan.c:2217:37: warning: implicit conversion from enumeration type
> > > 'enum lru_list' to different enumeration type 'enum node_stat_item'
> > > [-Wenum-conversion]
> > >         active = lruvec_page_state(lruvec, active_lru);
> > >                  ~~~~~~~~~~~~~~~~~         ^~~~~~~~~~
> > > mm/vmscan.c:2746:42: warning: implicit conversion from enumeration type
> > > 'enum lru_list' to different enumeration type 'enum node_stat_item'
> > > [-Wenum-conversion]
> > >         file = lruvec_page_state(target_lruvec, LRU_INACTIVE_FILE);
> > >                ~~~~~~~~~~~~~~~~~                ^~~~~~~~~~~~~~~~~
> > > 
> > > Since it guarantees the relative order between the LRU items, fix it by
> > > using NR_LRU_BASE for the translation.
> > > 
> > > [1] http://lkml.kernel.org/r/20191107205334.158354-4-hannes@cmpxchg.org
> > > 
> > > Signed-off-by: Qian Cai <cai@lca.pw>
> > 
> > Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> > 
> > Thanks Qian!
> > 
> > Andrew, this is a fix for "mm: vmscan: enforce inactive:active ratio
> > at the reclaim root". Could you please fold this into that?
> 
> nvm, I see you already picked it up. Thank you!

Hmm, I don't see Andrew picked it yet.