Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3471976ybc; Mon, 18 Nov 2019 16:06:41 -0800 (PST) X-Google-Smtp-Source: APXvYqwKCLwV4RKyn3gLFiXR6aV974q5B1dzGNuTlsUx+1kGLA6iG22c0Wou80WmIYYGyS2Ozxb4 X-Received: by 2002:a17:906:234e:: with SMTP id m14mr29466228eja.94.1574122001788; Mon, 18 Nov 2019 16:06:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574122001; cv=none; d=google.com; s=arc-20160816; b=lRQtkZhimYcXf7EVSP+l44+/kVT6siHsHJ53O99yWiCh/SqTCX4hD72H/LBVNbuRPo z/GWM+vB2gMklhkqRcc4Xt1v1FW0sybq7zuE9jpbjSkjLa41++qp6bm9qyk1b2fD9NKr +Nhn8vebA781AE13uyIH6u6bmGAlAzKkkr7xuxgAt75ySpiKqFlRh0Njtj67bWNmkWQp gM85d06QTl5BV3z+KxZZ8QNtK3QEBdTt8H+T4QJrMBj8fkZupIWitWs47SPp2dEE6M35 hf+4CXa4wRrUhm+pxZZwpDrV2c+HfneU/S2gbmDLWfl33Msa2/oekkJk/TWDJ47HvpMo FAuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=ZtbvKjjnscKy4A6MuNeD3a3NFthr68OtKoL8RB+WxNo=; b=Ry+foEE2qe2AOVEr+Z/cEuyt9KBBw4y+FOvz3f57Q11R7IeujNs9cYyvcu5lFDWXd7 4rLpAygBhUM5aVuPg9kOPFjcmRri191dT26Xg39OxvwR0VWHWYRlAL8nsavDWJj5WFcG FXPJrFkwsC6MENzVSRmbOtmoMiZQYcEJ6BS/hgyn50XcSgFNhTnwCkAQ4jHH22gIEOOK CIyYfsm3mVvJywW51osWqxhiEpDSjztfjdmIozpRFDuJPJWCWBE63VJel0UIGk9jHMgl pqfPXPzcRRYAEeGC2q/ztPAuwIIiSa+WYG705YqjZ8mxalRTZAXXkdSYRjg1glPcD3WP d3Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=OwqIclI3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m23si13221270ejj.164.2019.11.18.16.06.06; Mon, 18 Nov 2019 16:06:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=OwqIclI3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbfKSAEU (ORCPT + 99 others); Mon, 18 Nov 2019 19:04:20 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:33572 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726809AbfKSAET (ORCPT ); Mon, 18 Nov 2019 19:04:19 -0500 Received: by mail-oi1-f193.google.com with SMTP id m193so17185893oig.0 for ; Mon, 18 Nov 2019 16:04:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZtbvKjjnscKy4A6MuNeD3a3NFthr68OtKoL8RB+WxNo=; b=OwqIclI3keeY7VHTJMp42XcFMnSTpvkqGJgi1VHbv9P05zsqk7I4qEew1vlPCtyxE6 NtIAzveBsEu4kp70hWM+c+0r8DFE2JfAuqsFbN0yMpKcYrac8GPNaBuUxFR2EypImxtG TbR3Gp8qoV/FATMkEKzlAggAnAqeHJJgJMZccBlQX3YSC1H5g1ptRg934gVSvL4odkQm wN0l/Z3VtNzyskVviilqa+8hpfN1DGw5KiJZiWyXEP/sX3mSW9PujfWr8BAiH/OJoUMU BEXRq1HBY8xK18/ZQAcIxHS4HLunPih16a070i5KPwuvbR2SMnxCy8MdUDiXvgBRovMR 2nUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZtbvKjjnscKy4A6MuNeD3a3NFthr68OtKoL8RB+WxNo=; b=NdUJkSZFqZyACpOVKWfriYrTw3r1uJxA5sDAFxQ98BQXoGnAujgY85VCCAHpHhaiJO msTPGOtCcP6xCDtdyA+2kDF9L1pzZbKPfYIUsPrvryIWs58ru51fuFA/sSOiPxMGnVxL UJf7lpnOlVahv/z0uO5W76mwl6Uzgrk6iLvGJz/tvnjUDdOqIyovOqy0zwUM5ddRMgvA RKltlTEThmxv9JheOnNzAlJsBRnw09A8GPWYvGmSUxjjVJxwyz7wgrxdvAqwwM164Nhs /KOi9jwh3dSLBMax5+yt4UzjG0S38yl/YQEYztDpwZuEaSPAvXyAUzUqPuXJ+8suz/3U w53w== X-Gm-Message-State: APjAAAUn+rOYEse4jkMmpGezuE10dvSa9ufXuqjASJGiLAR8whbx8Ysn C5VL3ft1oXQMxIRVGeeY6Tg6LEGqyH9OKxnG+v8uaA== X-Received: by 2002:aca:ea57:: with SMTP id i84mr1382576oih.73.1574121858711; Mon, 18 Nov 2019 16:04:18 -0800 (PST) MIME-Version: 1.0 References: <20191025044721.16617-1-alastair@au1.ibm.com> <20191025044721.16617-9-alastair@au1.ibm.com> <8232c1a6-d52a-6c32-6178-de082174a92a@linux.ibm.com> <02374c9a-39fb-5693-3d9c-aa7e7674a6c1@linux.ibm.com> In-Reply-To: <02374c9a-39fb-5693-3d9c-aa7e7674a6c1@linux.ibm.com> From: Dan Williams Date: Mon, 18 Nov 2019 16:04:07 -0800 Message-ID: Subject: Re: [PATCH 08/10] nvdimm: Add driver for OpenCAPI Storage Class Memory To: Andrew Donnellan Cc: Frederic Barrat , "Alastair D'Silva" , alastair@d-silva.org, Oscar Salvador , Michal Hocko , David Hildenbrand , Alexey Kardashevskiy , Wei Yang , Masahiro Yamada , Paul Mackerras , Ira Weiny , Thomas Gleixner , Pavel Tatashin , Dave Jiang , linux-nvdimm , Vishal Verma , Krzysztof Kozlowski , Mahesh Salgaonkar , Arnd Bergmann , Greg Kurz , Nicholas Piggin , Qian Cai , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Hari Bathini , David Gibson , Linux MM , Greg Kroah-Hartman , Linux Kernel Mailing List , Andrew Morton , linuxppc-dev Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 18, 2019 at 3:48 PM Andrew Donnellan wrote: > > On 15/11/19 3:35 am, Dan Williams wrote: > >> Have you discussed with the directory owner if it's ok to split the > >> driver over several files? > > > > My thought is to establish drivers/opencapi/ and move this and the > > existing drivers/misc/ocxl/ bits there. > > Is there any other justification for this we can think of apart from not > wanting to put this driver in the nvdimm directory? OpenCAPI drivers > aren't really a category of driver unto themselves. The concern is less about adding to drivers/nvdimm/ and more about the proper location to house opencapi specific transport and enumeration details. The organization I'm looking for is to group platform transport and enumeration code together similar to how drivers/pci/ exists independent of all pci drivers that use that common core. For libnvdimm the enumeration is platform specific and calls into the nvdimm core. This is why the x86 platform persistent memory bus driver lives under drivers/acpi/nfit/ instead of drivers/nvdimm/. The nfit driver is an ACPI extension that translates ACPI details into libnvdimm core objects. The usage of "ocxl" in the source leads me to think part of this driver belongs in a directory that has other opencapi specific considerations.