Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3553239ybc; Mon, 18 Nov 2019 17:25:08 -0800 (PST) X-Google-Smtp-Source: APXvYqym+o8myfYjbnUqBekS/ziOhpmKdDxVSn3bwQ42OVGSknvHRvgjPYg/JF4gjb2z97sSQlZj X-Received: by 2002:a17:906:6043:: with SMTP id p3mr31107165ejj.103.1574126708196; Mon, 18 Nov 2019 17:25:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574126708; cv=none; d=google.com; s=arc-20160816; b=sJjnjt3F4Ly70HTe383hc+l7+Y0Ip0FUBQnK6p3RVuonnnf4A8XYXYWpmDcG2GFYOp V0SH4cjiyWEIEBIcwDh4Hhu7FL5i901Jmdud2xQ8CP7tkeRd3AVYEtmrbfO2gddkk2yk mWPj+jgdIF5UfOmW5X//M7nr3cf2jV2b/oltkMtZVFYXQY8BLRs0GED1NUuRN3YLbzTi UYm9oFnQ3lwvNpSbjj5LInOdHhLuD+LeGHSfRq9RwIfIEJTBqTV7DqJH9jBy+VlNU8Oa zFwPWbCX50Tg1M7MrI7d7mNtowlvlvEQBS2fVeMaCTmp+BAvxiIjA9Wq/MeQoluc5tHt d7XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=oqWIGX8poXVo9HbfXnJmYVJt3R8N/MtOCDIP2J/LyCA=; b=C9vacYT/qPYWM2V8spBUfrnjJJOqmyE3WLs12eBq1EPTBn8T0gXkO98mKfw/ogcysl lIcdCpRaPixv/gQ5zN0xIf2aRTWsdn6yqo8xKz69OAu1zd1GMP27OSMe4PXI1CPEqKqn FukNxqY1lf9qnQ8Ib7pDwFwtOwUESRtb1pRAa33YDDd6aSV0FjKQKKLf91znkUbYXdAa MqjzPOrmiSIKHD+Yx28lyVSehXge096fO4k6PgBqMpMkXMxN4kWFF4+bcCwkV1UkcHtI KjF7Dv+fKrpw/Elzz35nYPb0hXmGm/+msIngmPseDF2OX4a2iVBTv0PPEWFVgOQ4CfXC H+UQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o2si15809511edj.290.2019.11.18.17.24.44; Mon, 18 Nov 2019 17:25:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727092AbfKSBXD (ORCPT + 99 others); Mon, 18 Nov 2019 20:23:03 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:52208 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726761AbfKSBXD (ORCPT ); Mon, 18 Nov 2019 20:23:03 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 71099150FAE71; Mon, 18 Nov 2019 17:23:02 -0800 (PST) Date: Mon, 18 Nov 2019 17:23:01 -0800 (PST) Message-Id: <20191118.172301.1298479853205739098.davem@davemloft.net> To: hslester96@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, mripard@kernel.org, wens@csie.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: mdio-sun4i: add missed regulator_disable in remove From: David Miller In-Reply-To: <20191118114115.25608-1-hslester96@gmail.com> References: <20191118114115.25608-1-hslester96@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 18 Nov 2019 17:23:02 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan Date: Mon, 18 Nov 2019 19:41:15 +0800 > The driver forgets to disable the regulator in remove like what is done > in probe failure. > Add the missed call to fix it. > > Signed-off-by: Chuhong Yuan Applied, thanks.