Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andy Duan <fugang.duan@nxp.com>
To:     Chuhong Yuan <hslester96@gmail.com>
CC:     "David S . Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH net v3] net: fec: fix clock count mis-match
Thread-Topic: [EXT] [PATCH net v3] net: fec: fix clock count mis-match
Thread-Index: AQHVngpPN2duB9UCX06qCEzQ+nC0SKeRup8A
Date:   Tue, 19 Nov 2019 01:49:29 +0000
Message-ID: <VI1PR0402MB3600A4B2E81637B834D7DCC4FF4C0@VI1PR0402MB3600.eurprd04.prod.outlook.com>
References: <20191118121826.26353-1-hslester96@gmail.com>
In-Reply-To: <20191118121826.26353-1-hslester96@gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6997faa9-a88f-4b56-d913-08d76c92b7bd
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2019 01:49:29.7913
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5Gg8BJGMslUyczq7RvRQ/kpSL80PVDhulZiYTs1EYTi1Ydma/K5XacQCLU0m0jBwQHHjw5HQS/JuYf6LNk+xzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3503
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Chuhong Yuan <hslester96@gmail.com> Sent: Monday, November 18, 2019 8=
:18 PM
> pm_runtime_put_autosuspend in probe will call suspend to disable clks
> automatically if CONFIG_PM is defined. (If CONFIG_PM is not defined, its
> implementation will be empty, then suspend will not be called.)

suspend -> runtime suspend
>=20
> Therefore, we can call pm_runtime_get_sync to resume it first to enable c=
lks,
resume -> runtime resume
> which matches the suspend. (Only when CONFIG_PM is defined, otherwise
suspend -> runtime suspend
> pm_runtime_get_sync will also be empty, then resume will not be called.)
>=20
> Then it is fine to disable clks without causing clock count mis-match.
>=20
> Fixes: c43eab3eddb4 ("net: fec: add missed clk_disable_unprepare in
> remove")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index a9c386b63581..4bb30761abfc 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -3636,6 +3636,11 @@ fec_drv_remove(struct platform_device *pdev)
>         struct net_device *ndev =3D platform_get_drvdata(pdev);
>         struct fec_enet_private *fep =3D netdev_priv(ndev);
>         struct device_node *np =3D pdev->dev.of_node;
> +       int ret;
> +
> +       ret =3D pm_runtime_get_sync(&pdev->dev);
> +       if (ret < 0)
> +               return ret;
>=20
>         cancel_work_sync(&fep->tx_timeout_work);
>         fec_ptp_stop(pdev);
> @@ -3643,15 +3648,17 @@ fec_drv_remove(struct platform_device *pdev)
>         fec_enet_mii_remove(fep);
>         if (fep->reg_phy)
>                 regulator_disable(fep->reg_phy);
> -       pm_runtime_put(&pdev->dev);
> -       pm_runtime_disable(&pdev->dev);
> -       clk_disable_unprepare(fep->clk_ahb);
> -       clk_disable_unprepare(fep->clk_ipg);
> +
>         if (of_phy_is_fixed_link(np))
>                 of_phy_deregister_fixed_link(np);
>         of_node_put(fep->phy_node);
>         free_netdev(ndev);
>=20
> +       clk_disable_unprepare(fep->clk_ahb);
> +       clk_disable_unprepare(fep->clk_ipg);
> +       pm_runtime_put_noidle(&pdev->dev);
> +       pm_runtime_disable(&pdev->dev);
> +
>         return 0;
>  }
>=20
> --
> 2.24.0