Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3580086ybc; Mon, 18 Nov 2019 17:59:44 -0800 (PST) X-Google-Smtp-Source: APXvYqxORlZz1XuoBtiU7rzv+XTtT+QnihUuiK1WWlB4NYycUryW3hEC7Snu7jTCXu4d0tjh1l3y X-Received: by 2002:a17:906:cca:: with SMTP id l10mr31125630ejh.161.1574128784622; Mon, 18 Nov 2019 17:59:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574128784; cv=none; d=google.com; s=arc-20160816; b=FP6+oGiXralZSSDRm1+wDvMlUK2F7DfxmAA30EIw62EQxnA5kioAg2AmpetBSFsqhW ehWs0n70VYWwE9fbHeZ5qc5bjHxdrtRDHYzMJRrpAN3YWVSADspzCLSHolM1vhTeMBpC 8QQarVHpqinmYjeoojuK2g8x1me5NYccNcfm1+5yC7MxosLKi8JOKbAzrpZdCpDQarQ0 6V/bjA0U/JzUPgnbJ7mxP3ifEoUahNZS4llMa0Zpcx11oPQ0Zh7VQpUy8cQiEHh+c2QP a7ReCQ7K2cMWXGR2tfoephNChdVA6qNznfqddwdfhAMkLZi8t6rOYQ7hApOpBIgPb/hy cVXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=jQAyNDcXc3mMZ0d+IwtcqodOYkng6N+Yo0N8K9bTquA=; b=W9l+nVUCETuxH5oOXaKRTb/PhCuoxZUdATOoB8WJ+fBPVE7sWKwCv0TYX1iBOk4TxT LkPr4wIE7vj9P+YjBm/pIT1+Tyhg5yXREMcH7r3g+T1s5yBPDEfFaRpXA4stHFEHlv/n +mEKaRU9J/LIB0Qa9SNFsBej26yxpWanuC7HFCfNeJA5i1KJr8rrAtwfMGgxok/Z6X9k oGrPeAl+5rmZGWEp7ciR9DNVo2z6SmaMgzzCf4LSZsO1i6UhNiP+3FUkJfTwOhclTEx8 AoOVqRH8LsvU6OxKQfgIj5ycdY5FwxwOsd1GeuDzjsvkNiMsTdj8ZpafbIpCj/IDtlhb dogw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o25si8065385ejc.52.2019.11.18.17.59.19; Mon, 18 Nov 2019 17:59:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727117AbfKSB6W (ORCPT + 99 others); Mon, 18 Nov 2019 20:58:22 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:52718 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726761AbfKSB6W (ORCPT ); Mon, 18 Nov 2019 20:58:22 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 36CB415102289; Mon, 18 Nov 2019 17:58:21 -0800 (PST) Date: Mon, 18 Nov 2019 17:58:18 -0800 (PST) Message-Id: <20191118.175818.1172073606217291260.davem@davemloft.net> To: jtoppins@redhat.com Cc: netdev@vger.kernel.org, aelior@marvell.com, skalluru@marvell.com, GR-everest-linux-l2@marvell.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] bnx2x: initialize ethtool info->fw_version before use From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 18 Nov 2019 17:58:21 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonathan Toppins Date: Mon, 18 Nov 2019 12:07:53 -0500 > probe begin { printf("net-info version 01.01\n")} > > function memset(msg:long) %{ > memset((char*)STAP_ARG_msg,-1,196); > %} > > probe module("bnx2x").function("bnx2x_get_drvinfo") > { > printf("In function\n"); > memset(register("rsi")); This makes no sense. This function is called with the buffer cleared to zero. You're scrambling something to simulate a "bug", but that will never be scrambled in reality.