Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1665ybc; Mon, 18 Nov 2019 18:53:26 -0800 (PST) X-Google-Smtp-Source: APXvYqwTnX/65SbQSfOXJsASiLBeEctca1/YBvNgh+VUED/Mjufjrn6MdN5JK43/lZN56th8W/X5 X-Received: by 2002:a17:906:6093:: with SMTP id t19mr31186544ejj.50.1574132005953; Mon, 18 Nov 2019 18:53:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574132005; cv=none; d=google.com; s=arc-20160816; b=G+3Fh1Nh76tJJAzdOrVLfhUUGUDvw9jq7xnAGeeZsdxHB40IfZ3rSCj6ZNJZXaDW9z tpVbwyTCtLUI5WIZLcY8Fx8xTPd2lDVQ+6QvCdNsFlyH107FMOf1JFC1urTi2lV+jp5v DVEco/VkBcMWfSWynIW0wyYWknt7z3k2cvDX3clefvo3zGmUMdBRimURgnVGFItF2cNY uT/X8AkCCD3WVFKt4G1/1hWOxxPeubJKaChs/tJnWl9w9F7pqm2kjP26wDaJvX0lajqW d3SPu5FMILPM9wD1rwi0Jy71XS23ALkfrA3DBmmkyD7GXA1kqb4QvRypH7mDiSv3sbS3 rBRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:user-agent:organization:references:in-reply-to:date:cc :to:from:subject; bh=Z8wG4HMcRAmMdP+3PnY28hh9FAI3/AfSDPnHuzxyy1k=; b=f1ABUeg6ceXePhAfcppjSascGbqr4KZAG+HCmwwg5jsTx4L6jHtKQVPuDcoDnD0ZNc dQKzvvonNXLMTZAA4Z2XZB5L8zTFmqZd7NmN/vmUG55ojkiT98zCeAxwm7bzeaXPwIqG /XBGksf+HvUtb9bsdiIKbrnAevdMFevqNa/eEgF7ic0eFB4Tudr0JK6KSgEDw+vHuiN3 7XVp/VhGoANOc960HfhvNIWb69D+tzUl3UVSRY/9EIizQJficwswJzTEssh9htx+s//D rwGUWy3H6Cbpy/2GE/epK6sk27gpuUjDHFbc9fbwN3Snoq1P5dQR6sqRLXWXiXffCEj6 PL1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i15si12834999ejz.434.2019.11.18.18.52.59; Mon, 18 Nov 2019 18:53:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727352AbfKSCso (ORCPT + 99 others); Mon, 18 Nov 2019 21:48:44 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34638 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727146AbfKSCso (ORCPT ); Mon, 18 Nov 2019 21:48:44 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xAJ2kuCS118554 for ; Mon, 18 Nov 2019 21:48:41 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2way216047-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 18 Nov 2019 21:48:41 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 19 Nov 2019 02:48:39 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 19 Nov 2019 02:48:31 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xAJ2mUkX393582 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Nov 2019 02:48:30 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C46E1A405C; Tue, 19 Nov 2019 02:48:30 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6D8F3A4054; Tue, 19 Nov 2019 02:48:30 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 19 Nov 2019 02:48:30 +0000 (GMT) Received: from adsilva.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id D0373A012A; Tue, 19 Nov 2019 13:48:25 +1100 (AEDT) Subject: Re: [PATCH 08/10] nvdimm: Add driver for OpenCAPI Storage Class Memory From: "Alastair D'Silva" To: Andrew Donnellan , Dan Williams , Frederic Barrat Cc: Oscar Salvador , Michal Hocko , David Hildenbrand , Alexey Kardashevskiy , Wei Yang , Keith Busch , Masahiro Yamada , Paul Mackerras , Ira Weiny , Thomas Gleixner , Pavel Tatashin , Dave Jiang , linux-nvdimm , Vishal Verma , Krzysztof Kozlowski , Mahesh Salgaonkar , Arnd Bergmann , Greg Kurz , Nicholas Piggin , Qian Cai , =?ISO-8859-1?Q?C=E9dric?= Le Goater , Hari Bathini , David Gibson , Linux MM , Greg Kroah-Hartman , Linux Kernel Mailing List , Andrew Morton , linuxppc-dev Date: Tue, 19 Nov 2019 13:48:26 +1100 In-Reply-To: <02374c9a-39fb-5693-3d9c-aa7e7674a6c1@linux.ibm.com> References: <20191025044721.16617-1-alastair@au1.ibm.com> <20191025044721.16617-9-alastair@au1.ibm.com> <8232c1a6-d52a-6c32-6178-de082174a92a@linux.ibm.com> <02374c9a-39fb-5693-3d9c-aa7e7674a6c1@linux.ibm.com> Organization: IBM Australia Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.1 (3.34.1-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19111902-0020-0000-0000-0000038A0D94 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19111902-0021-0000-0000-000021E0371A Message-Id: <7fd5a4571062a06da8f09f18300794b48ead5dc1.camel@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-18_08:2019-11-15,2019-11-18 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=886 malwarescore=0 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 clxscore=1015 mlxscore=0 priorityscore=1501 impostorscore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1911190024 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-11-19 at 10:47 +1100, Andrew Donnellan wrote: > On 15/11/19 3:35 am, Dan Williams wrote: > > > Have you discussed with the directory owner if it's ok to split > > > the > > > driver over several files? > > > > My thought is to establish drivers/opencapi/ and move this and the > > existing drivers/misc/ocxl/ bits there. > > Is there any other justification for this we can think of apart from > not > wanting to put this driver in the nvdimm directory? OpenCAPI drivers > aren't really a category of driver unto themselves. > There is a precedent for bus-based dirs, eg. drivers/(ide|w1|spi) all contain drivers for both controllers & connected devices. Fred, how do you feel about moving the generic OpenCAPI driver out of drivers/misc? -- Alastair D'Silva Open Source Developer Linux Technology Centre, IBM Australia mob: 0423 762 819