Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp23127ybc; Mon, 18 Nov 2019 19:21:22 -0800 (PST) X-Google-Smtp-Source: APXvYqzcj0FpgrVuq0yx+0GhNJnYQc9qP9oHDBjhHv9+9+g3bg3gFmuhxo40HQWa5ibNk/QVF9cr X-Received: by 2002:a17:906:b7c6:: with SMTP id fy6mr32085910ejb.90.1574133682425; Mon, 18 Nov 2019 19:21:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574133682; cv=none; d=google.com; s=arc-20160816; b=khhIIEF7cexh+cMuxTfC1ReIiB1CJgSQJAcNnWxN4GfbDPb1nOZGfMGjbZTgs+e4bk ysJ3VVxHCQLLB6HK9vyQf0W8w/a6T7mf+YrjyyHVSdcJ56oUOpixbBbai3emN8tUXDfD 1bBk3UELiL5BXB1IQfP9y7rSgGehmuRv3v7xj3abZzoZ4R/DqxEwJnx11JgWmDUPayoN C504sIWoDB5fh6cGSNSEP+yYbjcs1W6WnH6vr60nAmcaAev+CJAc8SRDGNEt6F9PfqD/ sac/hmsoshZd1GtJANirY+Wlhrxuh9CHbE6PdP7JUa8y5T/jS4bCpKcS/RUJ5dACUuX1 hKUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=PW71dQIWialFHyWpgoG5UDLtreRXz1VE5C7xJGX63/4=; b=WKlJjD8rRZafRKA4XN4co8hBt3/Bb9VP9w2MzEBpYUWX1DGa3ycV7JMKNene+IPd70 zjupRSj8PqWUkk+oyIcB2ot3moXRsdxCwu6znpkBXcwjT7GLjDGL/oFJueZlOwtAsVAQ Al5gpFUQbdhXhl7DKLb7SqWjB2JlxFulLbtEjmYY/gviXuZKIPro5xsTD3B10ggqayF7 /mW5cOjATo7N3Z+2KeB2Ev5ENb10Es7wb0KKOr/EwHgxuOPHSXTpgoht/527J4zpNrmz mpj5VmuF5JO7bDg4v9C2L+V8NAammObfjBTnYG2rPgzenJ47berW9riMDjbN6xygnyB9 0mRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=C+ZSeX7W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h37si15612700eda.249.2019.11.18.19.20.59; Mon, 18 Nov 2019 19:21:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=C+ZSeX7W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727573AbfKSDUB (ORCPT + 99 others); Mon, 18 Nov 2019 22:20:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:55088 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727242AbfKSDUB (ORCPT ); Mon, 18 Nov 2019 22:20:01 -0500 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 811A42230F; Tue, 19 Nov 2019 03:20:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574133600; bh=3H8618+VZUATiI2/5A4JcV1lJ5zgJKbaPCe1NM/Frhg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C+ZSeX7WtzWw+bDNgjLTNoRFPKHkyXIzhwHNBrBg5uwCRy7Z672TtlGUuudTab4UN oO+2ESxb6DFOD1OOVp5DMCs9Dqtm1DRoy/taFfPcKwmWJbobkWsHnBRtppZCRZxr7f FeRlA5SGbLqbR4WZ3IilPr8U1/Dss5Bgb2XHf01c= Date: Mon, 18 Nov 2019 19:19:59 -0800 From: Eric Biggers To: Sun Ke Cc: josef@toxicpanda.com, axboe@kernel.dk, linux-block@vger.kernel.org, nbd@other.debian.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nbd:fix memory leak in nbd_get_socket() Message-ID: <20191119031959.GK3147@sol.localdomain> References: <1574133408-77202-1-git-send-email-sunke32@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1574133408-77202-1-git-send-email-sunke32@huawei.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 19, 2019 at 11:16:48AM +0800, Sun Ke wrote: > Before return NULL,put the sock first. > > Fixes: cf1b2326b734 ("nbd: verify socket is supported during setup") Since this commit went to stable kernels, can you add Cc stable to this one? Thanks, - Eric