Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp78946ybc; Mon, 18 Nov 2019 20:43:23 -0800 (PST) X-Google-Smtp-Source: APXvYqwG7PZzJityNfy8A31uw8K7csEjNpW1BSuEliP/smBgibOGh/OwiDUvtpi18jObgzBC+pEv X-Received: by 2002:a17:906:f18a:: with SMTP id gs10mr31783739ejb.107.1574138603123; Mon, 18 Nov 2019 20:43:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574138603; cv=none; d=google.com; s=arc-20160816; b=EJGF/zCE3/tM17jkKtRtoEwXFfY9+i4wym5yf2e22ZgY8VltT8OTyUeqkxgA3CPZQ6 tJm+91FZ1Lct5yMhcmu00mIVTl7dfAs5FnkzjP8keoZ12kkiQWJxY/gynbKHPXxEYEwj wCNCmEsF9gYxRaLj40EjIqGMf4lZoYjxV7NCegIDnlv0j8JC468sD2JuVDzzecdw1ar2 PaXUhul+tN4JKeJd5xWKnu4LVkqJtO2H8anj02NW/OBFgb+OMDRK0u9NS0f+NjGLZ176 /LHI0HaLjRc5a10BKj7/S3eBj23Zqhn8pz2FqagO1YmBTzaQf/clQxsm8SnQeGJuMxSH DMTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=m3MHq1VeKFp127FUICx04ubISK/Dg9APGUYHbc8GCeE=; b=Hvw56BZzpVufY1RiTDyXp0KM4ep/1KK+/jIHdosqX15UUbv0Tn4UKfN1kjTunpLu8y oNAbxlzhuOtmy7/EVUBGj3GJuZbq+2YM+5z46NyrS7T3z9OTbXJBWYquiQ7HAVYAz69+ T6O6DXfOKDu5ASiI6JpHpLIRHt+3N+MSD2Bl90CzDtyCUMydckjtiEiQ2tzP1XWV+byc 4rYnslDvGheCFO8M+FmKUqFBFPaCbbxXXNtttaIjcoxOrUuCuuqyjgekB26Cru1PxdU4 m4uQfx5LplC0oN6A8KpLCs/ZhMf1acvwEdV3DF+PWvIx90OjKGWgBs43V4cwDwYi1cwa ajJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=05QWaL6g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j20si13019967ejm.348.2019.11.18.20.42.58; Mon, 18 Nov 2019 20:43:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=05QWaL6g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727014AbfKSElu (ORCPT + 99 others); Mon, 18 Nov 2019 23:41:50 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:43568 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726748AbfKSElu (ORCPT ); Mon, 18 Nov 2019 23:41:50 -0500 Received: by mail-oi1-f193.google.com with SMTP id l20so17637987oie.10 for ; Mon, 18 Nov 2019 20:41:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m3MHq1VeKFp127FUICx04ubISK/Dg9APGUYHbc8GCeE=; b=05QWaL6gVTbgGCnZuO1yjSnjhWRi3w56l7hdlFSvvB8HiMDjBUO8yQ0RvJvlVo0qrc LDTYINUM5Yz7PgMGOy/bFHjxL6KJLqarZnNaOW355ivIXYFifzzcwVSAotpWlAb448cg cGiHNiToS3o3BeltrXgUR8vT8b73Tsz627J+9LPszqNyQyTUj33nxl3KHG3AHLooI3Gd yVTaO6OHo0EuDIIK5dpNL5RXxotYXkd8Hp4zLWlaTagZrtXbh5DsQV4EK9s/xTexTKeu pm4BC3RVxJ3UeExcy4v3Sr3p2qNqBENFM83bjAQnXRlcbCyQKBclbh76qG9xPSZT8Gty L9hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m3MHq1VeKFp127FUICx04ubISK/Dg9APGUYHbc8GCeE=; b=ZMNQEO6JDibuq1sk6RcUZGGpal/ON3WBfRLbTrJUbET7LdGU4Vw6T4IKhTot8w/MIz Gbu7qdoUIMP2nerCzZtqKSeJM/kgZeF5djylVkiiTu9L7Z0tTbjmm4F+zKXXUPhqZgRJ AzwcvNA42CmsCi46Aleh2kDOA3ZkhCAVyvXRfS6hz78bbVLJ2emxC6xfm0blidjh4XU+ C76C+jTp7NyBasyAMUFpcji2jFdFeEl2xSGnAqkrE/xA27ZUrhSAVy2gXiV7WJJYy208 Jky5gRST7cJYPxH4ZiwGy2RlfDaeFS0qPwfuiu5N3wlkiRVnznkXpXLRtnAa5aBPh76w UXRg== X-Gm-Message-State: APjAAAVJ8gdPwpREFrA/SP99L9q470/xCiVQkMNSW1pg24TuONw6fUgS gkPKPY1nwbl7cz8yJRs5vPzHaCRNCqVQhptdhvwAWg== X-Received: by 2002:aca:55c1:: with SMTP id j184mr2403758oib.105.1574138509410; Mon, 18 Nov 2019 20:41:49 -0800 (PST) MIME-Version: 1.0 References: <20191025044721.16617-1-alastair@au1.ibm.com> <20191025044721.16617-9-alastair@au1.ibm.com> <8232c1a6-d52a-6c32-6178-de082174a92a@linux.ibm.com> <02374c9a-39fb-5693-3d9c-aa7e7674a6c1@linux.ibm.com> <7fd5a4571062a06da8f09f18300794b48ead5dc1.camel@au1.ibm.com> <33b6f6b2-5ca1-7c08-01db-6aad73f9a0ec@linux.ibm.com> In-Reply-To: <33b6f6b2-5ca1-7c08-01db-6aad73f9a0ec@linux.ibm.com> From: Dan Williams Date: Mon, 18 Nov 2019 20:41:37 -0800 Message-ID: Subject: Re: [PATCH 08/10] nvdimm: Add driver for OpenCAPI Storage Class Memory To: Andrew Donnellan Cc: "Alastair D'Silva" , Frederic Barrat , Oscar Salvador , Michal Hocko , David Hildenbrand , Alexey Kardashevskiy , Wei Yang , Keith Busch , Masahiro Yamada , Paul Mackerras , Ira Weiny , Thomas Gleixner , Pavel Tatashin , Dave Jiang , linux-nvdimm , Vishal Verma , Krzysztof Kozlowski , Mahesh Salgaonkar , Arnd Bergmann , Greg Kurz , Nicholas Piggin , Qian Cai , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Hari Bathini , David Gibson , Linux MM , Greg Kroah-Hartman , Linux Kernel Mailing List , Andrew Morton , linuxppc-dev Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 18, 2019 at 7:29 PM Andrew Donnellan wrote: > > On 19/11/19 1:48 pm, Alastair D'Silva wrote: > > On Tue, 2019-11-19 at 10:47 +1100, Andrew Donnellan wrote: > >> On 15/11/19 3:35 am, Dan Williams wrote: > >>>> Have you discussed with the directory owner if it's ok to split > >>>> the > >>>> driver over several files? > >>> > >>> My thought is to establish drivers/opencapi/ and move this and the > >>> existing drivers/misc/ocxl/ bits there. > >> > >> Is there any other justification for this we can think of apart from > >> not > >> wanting to put this driver in the nvdimm directory? OpenCAPI drivers > >> aren't really a category of driver unto themselves. > >> > > > > There is a precedent for bus-based dirs, eg. drivers/(ide|w1|spi) all > > contain drivers for both controllers & connected devices. > > > > Fred, how do you feel about moving the generic OpenCAPI driver out of > > drivers/misc? > > Instinctively I don't like the idea of creating a whole opencapi > directory, as OpenCAPI is a generic bus which is not tightly coupled to > any particular application area, and drivers for other OpenCAPI devices > are already spread throughout the tree (e.g. cxlflash in drivers/scsi). I'm not suggesting all opencapi drivers go there, nor the entirety of this driver, just common infrastructure. That said, it's hard to talk about specifics given the current state of the patch set. I have not even taken a deeper look past the changelog as this 3K lines-of-code submission needs to be broken up into smaller pieces before we settle on what pieces belong where. Just looking at the diffstat, at a minimum it's not appropriate for them to live in drivers/nvdimm/ directly, drivers/nvdimm/oxcl/ would be an acceptable starting point.