Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp81845ybc; Mon, 18 Nov 2019 20:47:53 -0800 (PST) X-Google-Smtp-Source: APXvYqyNNakqOv+JbiMnHhI9SnRnWNGanF/hstMDqP0VtcqHsoqN2uGl2vIL2ihVmHEzkOYica/f X-Received: by 2002:a17:906:f0c9:: with SMTP id dk9mr32335961ejb.56.1574138873466; Mon, 18 Nov 2019 20:47:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574138873; cv=none; d=google.com; s=arc-20160816; b=Sc3B+FIFvEjWWxqZexRA6Je1QpgDd4UPYkSZhHcebUl29zqnNgCe1VRgDiXAwR7/K3 MIc36XAU2x764V6OwYt20P7cEcAMKc0V8Utfu1wGU6zXhlX2xDT8Au6CriEUW5jKvTYk IUHPgw4IpzAKzCnO74QaTLgiyl2DEq7Pvg0NhOnP6wOSxdcGDTn1/rNX51wvyyENbgjX 2RbGSM8+47vyn3MpGyDsEeuXPKCPupc2orA/9XarVLze1MFzgA5fKAPzoxBsZWyblngh SNoVWW5U/HLP11jJaW3sO3YHYBn2aDqoqoUSHJ3JwH+fr1CnEYeyA8aSXdTXnp9EY4xh /yFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=P4T/RLDFvJ6qN2Upx5OjPezOF8dhMaemsOxf3TvuhPA=; b=evAyYRHavMSmvPai9llG0Bp/NnRGPSWjQjQVEL+V3m7BL21OADJMyCfQpkthqzHFH9 PhR9v9Xa4Bc9m1+b/RNyplY4J98tI+fP6ENpAvhBBeGyTTnMcEQ00HHttW2hEluk3h9X ftHgR5iLSQ3Hth6smXS8RlmQLExNBvaNfJHs3ZWbnX+9qzJPz8Y++ph1CP83jHdI174E s4sla1KJoqkg8I0mq4orI6VXIGc/JKD6tIoRRNqJVUS6jRkLXy1Q8hLcJGGaItpzzmIn zNXkdBmkpCxBNYMQ3lucNA8Q2dcS2e/KgcMZbOiunFAvNURVfGhW58qXVIy19UZQo3jF plNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=qemxDWm3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id uz25si12947352ejb.43.2019.11.18.20.47.29; Mon, 18 Nov 2019 20:47:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=qemxDWm3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727053AbfKSEpP (ORCPT + 99 others); Mon, 18 Nov 2019 23:45:15 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:43836 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726911AbfKSEpP (ORCPT ); Mon, 18 Nov 2019 23:45:15 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAJ4hhOX077926; Tue, 19 Nov 2019 04:45:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=P4T/RLDFvJ6qN2Upx5OjPezOF8dhMaemsOxf3TvuhPA=; b=qemxDWm3kRD/JDCjIc5A9ANgWjO1V1RjB925J5trWKfuKX6zGu+s9b+xCqU5FDbq8pkb ViDcZTgranHhbycHozFYNKIMy49wuSZ4J98b1v5EMeqT1eTF3v+NRJMYT7XyBmwVGQSC HImP1ktnxRtnzFyvRgLtIeADr1mCYfhe1fTO4PMi21WyRePbGeAUeRMHWqkF41ls8pxd /ITTC/qiXvLytuf7LtGahRerzfsIkswZxMwhddjcqpcJ5VHjD2zjRgwI+zXVSOY3Rqg6 ZDzqfNI3YjieNoqBko1Q22dRMTAy/3TG50efPqJNaZJFNVaIgUh88tEBGGyFxTTKk2/y zw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2wa9rqcb1d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Nov 2019 04:45:09 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAJ4gXfD096995; Tue, 19 Nov 2019 04:45:08 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2wbxgdy50a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Nov 2019 04:45:08 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xAJ4j6Cf028121; Tue, 19 Nov 2019 04:45:06 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 18 Nov 2019 20:45:05 -0800 To: Finn Thain Cc: "James E.J. Bottomley" , "Martin K. Petersen" , "Michael Schmitz" , "Ondrej Zary" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] NCR5380: Unconditionally clear ICR after do_abort() From: "Martin K. Petersen" Organization: Oracle Corporation References: <4277b28ee2551f884aefa85965ef3c498344f301.1573875417.git.fthain@telegraphics.com.au> Date: Mon, 18 Nov 2019 23:45:03 -0500 In-Reply-To: <4277b28ee2551f884aefa85965ef3c498344f301.1573875417.git.fthain@telegraphics.com.au> (Finn Thain's message of "Sat, 16 Nov 2019 14:36:57 +1100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9445 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=653 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911190042 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9445 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=724 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911190042 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Finn, > When do_abort() succeeds, the target will go to BUS FREE phase and > there will be no connected command. Therefore, that function should > clear the Initiator Command Register before returning. It already does > so in case of NCR5380_poll_politely() failure; do the same for the > other error case too, that is, NCR5380_transfer_pio() failure. Applied to 5.5/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering