Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp137539ybc; Mon, 18 Nov 2019 22:00:08 -0800 (PST) X-Google-Smtp-Source: APXvYqxmEDcJ/dwIdz+p99YbmTkHuM8/zoGWIU8/WVNe+AHMMcILDkbnyZiVHSVPKpEsh02w5feG X-Received: by 2002:a17:906:1503:: with SMTP id b3mr2625352ejd.78.1574143207973; Mon, 18 Nov 2019 22:00:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574143207; cv=none; d=google.com; s=arc-20160816; b=oEBCcShWc5imMnZJRHn4CYYUjd3u2IUTx76Zzm/Lp7LswWfVI3gvSgUPI59pEG3zoN b2O6BlIO3Mu2Na0rPynU5wqZ5c+uNQa4vNPxQnJ5CP3En2UaPaxmH4yxuhUv2CoXYPdp 450PP0Z1b/9saa6VX5pbyhaBYo5E+EN+LDnh7vcSQMwz80DEDr8HJL4JBYTYkeL/8t9m AMnc9+D1kRnMWEww4Zmq8h1gtT+EqB2ZSWFzYYcv8qvaUWPzslSOfa1g7ae8745QVng7 MzrUZlTPDoYNLN+qpQ2NN81rkCANthjnm4ZNDGCdMr7oX7olz131eegty3PBawXrln0P jgxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gCaAUjePcXZIqM9YVx29WVAXZBegPNmJRKoYDvuq6cA=; b=JWJoOdvmhc3teZMni+vmAYvb8L6gL9DZtusaduC6/lte5XzNGBTqX+H+RQ/Hywx3A4 D7+OS63FBICvCuxJKjTDWAF82Q+cxtAd4vM+/WGUSFOZO7tapdo/bNLWtdLkamyZanh+ UcIZcOqum7iwxh6sTbUUTdbDO1//GW95N/zBFxq8kQQ7MgjnkXndLqo3zEyZ5BFQ+j26 NFhj8PK3XkOJaNfS0ray6kwFsOYelQdjE119vr6fRsmLFUKhdJJ09XfLQ4ApGWsZ+g2Z 6f5QKjOda3Qf5dSOtHbS0XxdTyOC40l711pLk8GI6zeAtnB6FSqbGmcPM7MupGgL4bx2 jcww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sHOZSXam; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p29si16530170eda.104.2019.11.18.21.59.43; Mon, 18 Nov 2019 22:00:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sHOZSXam; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731756AbfKSFvQ (ORCPT + 99 others); Tue, 19 Nov 2019 00:51:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:48592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731151AbfKSFvO (ORCPT ); Tue, 19 Nov 2019 00:51:14 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C3AA20862; Tue, 19 Nov 2019 05:51:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142673; bh=FpaPB9iIq88I6PI7mIlH8uxwmRVVBTJQKj37SXeRS/w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sHOZSXamq9eQd2b6moF4t3nyA+QKUsIuuZ9bTEF5Nl8AXK/q3Lemo1BqUCfWyV2/5 OSiKtJLxNeQ+YK2KtWNNuYIBWJEyGxHZM2hlgW+RPO13nfCt2RwAsrDu/AHFsUPAhu EmDZJshW5bRtnIwyto07SLpkJ1wrDRVWxEam/nlM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chao Yu , Jaegeuk Kim , Sasha Levin Subject: [PATCH 4.14 160/239] f2fs: fix to recover inodes uid/gid during POR Date: Tue, 19 Nov 2019 06:19:20 +0100 Message-Id: <20191119051333.327196149@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191119051255.850204959@linuxfoundation.org> References: <20191119051255.850204959@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chao Yu [ Upstream commit dc4cd1257c86451cec3e8e352cc376348e4f4af4 ] Step to reproduce this bug: 1. logon as root 2. mount -t f2fs /dev/sdd /mnt; 3. touch /mnt/file; 4. chown system /mnt/file; chgrp system /mnt/file; 5. xfs_io -f /mnt/file -c "fsync"; 6. godown /mnt; 7. umount /mnt; 8. mount -t f2fs /dev/sdd /mnt; After step 8) we will expect file's uid/gid are all system, but during recovery, these two fields were not been recovered, fix it. Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/recovery.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c index db357e9ad5990..adbf2600c0908 100644 --- a/fs/f2fs/recovery.c +++ b/fs/f2fs/recovery.c @@ -201,6 +201,8 @@ static void recover_inode(struct inode *inode, struct page *page) char *name; inode->i_mode = le16_to_cpu(raw->i_mode); + i_uid_write(inode, le32_to_cpu(raw->i_uid)); + i_gid_write(inode, le32_to_cpu(raw->i_gid)); f2fs_i_size_write(inode, le64_to_cpu(raw->i_size)); inode->i_atime.tv_sec = le64_to_cpu(raw->i_atime); inode->i_ctime.tv_sec = le64_to_cpu(raw->i_ctime); -- 2.20.1